Utilise the new 'p4_read_pipe_lines' command
Now that we have the new command, we can utilise it and then eventually, isolate any changes required to the one place. Signed-off-by: Anand Kumria <wildfire@progsoc.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Anand Kumria committed
Aug 10, 2008 at 19:26 UTC
b340fa43017437988e233ed4fd8dc00042614071
1 file changed
+2
-2
contrib/fast-import/git-p4
+2
-2
@@ -371,7 +371,7 @@ def originP4BranchesExist():
371
372
def p4ChangesForPaths(depotPaths, changeRange):
373
assert depotPaths
374
- output = read_pipe_lines("p4 changes " + ' '.join (["%s...%s" % (p, changeRange)
374
+ output = p4_read_pipe_lines("changes " + ' '.join (["%s...%s" % (p, changeRange)
375
for p in depotPaths]))
376
377
changes = []
@@ -519,7 +519,7 @@ class P4Submit(Command):
519
# remove lines in the Files section that show changes to files outside the depot path we're committing into
520
template = ""
521
inFilesSection = False
522
- for line in read_pipe_lines("p4 change -o"):
522
+ for line in p4_read_pipe_lines("change -o"):
523
if line.endswith("\r\n"):
524
line = line[:-2] + "\n"
525
if inFilesSection: