git-send-email: replace "map" in void context with "for"
While using "map" instead of "for" or "map" instead of "grep" and vice-versa makes for interesting trivia questions when interviewing Perl programmers, it doesn't make for very readable code. Let's refactor this loop initially added in 8fd5bb7f44b (git send-email: add --annotate option, 2008-11-11) to be a for-loop instead. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Apr 2, 2021 at 13:34 UTC
b362acf575424bcfea6444ce6cbfe3c3aa3f1192
1 file changed
+2
-2
git-send-email.perl
+2
-2
@@ -217,12 +217,12 @@ sub do_edit {
217
$editor = Git::command_oneline('var', 'GIT_EDITOR');
218
}
219
if (defined($multiedit) && !$multiedit) {
220
- map {
220
+ for (@_) {
221
system('sh', '-c', $editor.' "$@"', $editor, $_);
222
if (($? & 127) || ($? >> 8)) {
223
die(__("the editor exited uncleanly, aborting everything"));
224
}
225
- } @_;
225
+ }
226
} else {
227
system('sh', '-c', $editor.' "$@"', $editor, @_);
228
if (($? & 127) || ($? >> 8)) {