cvsimport: always pass user data to "system" as a list
This avoids invoking the shell. Not only is it faster, but it prevents the possibility of interpreting our arguments in the shell. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Apr 30, 2008 at 00:36 UTC
b3bb5f76e6193db102b063187be854ef3842d89b
1 file changed
+1
-1
git-cvsimport.perl
+1
-1
@@ -767,7 +767,7 @@ sub commit {
767
waitpid($pid,0);
768
die "Error running git-commit-tree: $?\n" if $?;
769
770
- system("git-update-ref $remote/$branch $cid") == 0
770
+ system('git-update-ref', "$remote/$branch", $cid) == 0
771
or die "Cannot write branch $branch for update: $!\n";
772
773
if ($tag) {