resolve_ref(): use prefixcmp()
Terminate the link content string one step earlier, allowing prefixcmp() to be used instead of the less clear memcmp(). Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Michael Haggerty committed
Sep 15, 2011 at 23:10 UTC
b54cb795970628714a3a9fa0f4a73cd117b0207f
1 file changed
+2
-2
refs.c
+2
-2
@@ -520,8 +520,8 @@ const char *resolve_ref(const char *ref, unsigned char *sha1, int reading, int *
520
len = readlink(path, buffer, sizeof(buffer)-1);
521
if (len < 0)
522
return NULL;
523
- if (len >= 5 && !memcmp("refs/", buffer, 5)) {
524
- buffer[len] = 0;
523
+ buffer[len] = 0;
524
+ if (!prefixcmp(buffer, "refs/")) {
525
strcpy(ref_buffer, buffer);
526
ref = ref_buffer;
527
if (flag)