t/t5532-fetch-proxy.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Jan 4, 2016 at 10:10 UTC
b7cbbffb858688d9abfa7aff57e0c9b969a39621
1 file changed
+2
-2
t/t5532-fetch-proxy.sh
+2
-2
@@ -15,7 +15,7 @@ test_expect_success 'setup remote repo' '
15
cat >proxy <<'EOF'
16
#!/bin/sh
17
echo >&2 "proxying for $*"
18
-cmd=`"$PERL_PATH" -e '
18
+cmd=$("$PERL_PATH" -e '
19
read(STDIN, $buf, 4);
20
my $n = hex($buf) - 4;
21
read(STDIN, $buf, $n);
@@ -23,7 +23,7 @@ cmd=`"$PERL_PATH" -e '
23
# drop absolute-path on repo name
24
$cmd =~ s{ /}{ };
25
print $cmd;
26
-'`
26
+')
27
echo >&2 "Running '$cmd'"
28
exec $cmd
29
EOF