@matheusbsbs / matheus-bagliano / commits / b8469ad057
Fork 0

test-path-utils: Fix off by one, found by valgrind

When normalizing an absolute path, we might have to add a slash _and_ a NUL to the buffer, so the buffer was one too small. Let's just future proof the code and alloc PATH_MAX + 1 bytes. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Johannes Schindelin committed Jan 28, 2009 at 00:07 UTC b8469ad0578d6b84ec92752a5f8df3ca5828af77
1 file changed +1 -1
test-path-utils.c
+1 -1
@@ -3,7 +3,7 @@
3 int main(int argc, char **argv)
4 {
5 if (argc == 3 && !strcmp(argv[1], "normalize_absolute_path")) {
6 - char *buf = xmalloc(strlen(argv[2])+1);
6 + char *buf = xmalloc(PATH_MAX + 1);
7 int rv = normalize_absolute_path(buf, argv[2]);
8 assert(strlen(buf) == rv);
9 puts(buf);