refs.c: make ref_transaction_create a wrapper for ref_transaction_update
The ref_transaction_update function can already be used to create refs by passing null_sha1 as the old_sha1 parameter. Simplify by replacing transaction_create with a thin wrapper. Signed-off-by: Ronnie Sahlberg <sahlberg@google.com> Signed-off-by: Stefan Beller <sbeller@google.com> Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ronnie Sahlberg committed
Dec 5, 2014 at 00:08 UTC
bc9f2925fba2fee13f75bf0f149c0da7a4688bc2
1 file changed
+2
-25
refs.c
+2
-25
@@ -3623,31 +3623,8 @@ int ref_transaction_create(struct ref_transaction *transaction,
3623
int flags, const char *msg,
3624
struct strbuf *err)
3625
{
3626
- struct ref_update *update;
3627
-
3628
- assert(err);
3629
-
3630
- if (transaction->state != REF_TRANSACTION_OPEN)
3631
- die("BUG: create called for transaction that is not open");
3632
-
3633
- if (!new_sha1 || is_null_sha1(new_sha1))
3634
- die("BUG: create ref with null new_sha1");
3635
-
3636
- if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
3637
- strbuf_addf(err, "refusing to create ref with bad name %s",
3638
- refname);
3639
- return -1;
3640
- }
3641
-
3642
- update = add_update(transaction, refname);
3643
-
3644
- hashcpy(update->new_sha1, new_sha1);
3645
- hashclr(update->old_sha1);
3646
- update->flags = flags;
3647
- update->have_old = 1;
3648
- if (msg)
3649
- update->msg = xstrdup(msg);
3650
- return 0;
3626
+ return ref_transaction_update(transaction, refname, new_sha1,
3627
+ null_sha1, flags, 1, msg, err);
3628
}
3629
3630
int ref_transaction_delete(struct ref_transaction *transaction,