coccicheck: make batch size of 0 mean "unlimited"
If you have the memory to handle it, the ideal case is to run a single spatch invocation with all of the source files. But the only way to do so now is to pick an arbitrarily large batch size. Let's make "0" do this, which is a little friendlier (and doesn't otherwise have a useful meaning). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
May 8, 2019 at 03:07 UTC
bcb4edf7af7f10878dd75ccfc3fc0f7596f2d658
1 file changed
+7
-1
Makefile
+7
-1
@@ -1176,6 +1176,7 @@ SP_EXTRA_FLAGS =
1176
1177
# For the 'coccicheck' target; setting SPATCH_BATCH_SIZE higher will
1178
# usually result in less CPU usage at the cost of higher peak memory.
1179
+# Setting it to 0 will feed all files in a single spatch invocation.
1180
SPATCH_FLAGS = --all-includes --patch .
1181
SPATCH_BATCH_SIZE = 1
1182
@@ -2792,7 +2793,12 @@ endif
2793
2794
%.cocci.patch: %.cocci $(COCCI_SOURCES)
2795
@echo ' ' SPATCH $<; \
2795
- if ! echo $(COCCI_SOURCES) | xargs -n $(SPATCH_BATCH_SIZE) \
2796
+ if test $(SPATCH_BATCH_SIZE) = 0; then \
2797
+ limit=; \
2798
+ else \
2799
+ limit='-n $(SPATCH_BATCH_SIZE)'; \
2800
+ fi; \
2801
+ if ! echo $(COCCI_SOURCES) | xargs $$limit \
2802
$(SPATCH) --sp-file $< $(SPATCH_FLAGS) \
2803
>$@+ 2>$@.log; \
2804
then \