t9362-mw-to-git-utf8.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Apr 16, 2014 at 10:29 UTC
bd368a9baf5a42e2076ef4c8a35312ccab171452
1 file changed
+2
-2
contrib/mw-to-git/t/t9362-mw-to-git-utf8.sh
+2
-2
@@ -70,8 +70,8 @@ test_expect_success 'The shallow option works with accents' '
70
test_path_is_file mw_dir_4/Main_Page.mw &&
71
(
72
cd mw_dir_4 &&
73
- test `git log --oneline Néoà.mw | wc -l` -eq 1 &&
74
- test `git log --oneline Main_Page.mw | wc -l ` -eq 1
73
+ test $(git log --oneline Néoà.mw | wc -l) -eq 1 &&
74
+ test $(git log --oneline Main_Page.mw | wc -l ) -eq 1
75
) &&
76
wiki_check_content mw_dir_4/Néoà.mw Néoà &&
77
wiki_check_content mw_dir_4/Main_Page.mw Main_Page