fetch: refactor verbosity option handling into transport.[ch]
transport_set_verbosity() is now provided to transport users. Signed-off-by: Tay Ray Chuan <rctay89@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Tay Ray Chuan committed
Feb 24, 2010 at 20:50 UTC
bde873c52914b40377a12764cab926ee974c3f32
3 files changed
+10
-4
builtin-fetch.c
+1
-4
@@ -823,10 +823,7 @@ static int fetch_one(struct remote *remote, int argc, const char **argv)
823
die("Where do you want to fetch from today?");
824
825
transport = transport_get(remote, NULL);
826
- if (verbosity >= 2)
827
- transport->verbose = verbosity <= 3 ? verbosity : 3;
828
- if (verbosity < 0)
829
- transport->verbose = -1;
826
+ transport_set_verbosity(transport, verbosity);
827
if (upload_pack)
828
set_option(TRANS_OPT_UPLOADPACK, upload_pack);
829
if (keep)
transport.c
+8
@@ -1013,6 +1013,14 @@ int transport_set_option(struct transport *transport,
1013
return 1;
1014
}
1015
1016
+void transport_set_verbosity(struct transport *transport, int verbosity)
1017
+{
1018
+ if (verbosity >= 2)
1019
+ transport->verbose = verbosity <= 3 ? verbosity : 3;
1020
+ if (verbosity < 0)
1021
+ transport->verbose = -1;
1022
+}
1023
+
1024
int transport_push(struct transport *transport,
1025
int refspec_nr, const char **refspec, int flags,
1026
int *nonfastforward)
transport.h
+1
@@ -122,6 +122,7 @@ struct transport *transport_get(struct remote *, const char *);
122
**/
123
int transport_set_option(struct transport *transport, const char *name,
124
const char *value);
125
+void transport_set_verbosity(struct transport *transport, int verbosity);
126
127
int transport_push(struct transport *connection,
128
int refspec_nr, const char **refspec, int flags,