t/t5516-fetch-push.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Dec 23, 2015 at 14:45 UTC
bf45242ba7dbc23831d90a304572d29d4e1ec590
1 file changed
+2
-2
t/t5516-fetch-push.sh
+2
-2
@@ -16,7 +16,7 @@ This test checks the following functionality:
16
17
. ./test-lib.sh
18
19
-D=`pwd`
19
+D=$(pwd)
20
21
mk_empty () {
22
repo_name="$1"
@@ -422,7 +422,7 @@ test_expect_success 'push tag with non-existent, incomplete dest' '
422
test_expect_success 'push sha1 with non-existent, incomplete dest' '
423
424
mk_test testrepo &&
425
- test_must_fail git push testrepo `git rev-parse master`:foo
425
+ test_must_fail git push testrepo $(git rev-parse master):foo
426
427
'
428