pack-bitmap: drop repository argument from prepare_midx_bitmap_git()
We never look at the repository argument which is passed. This makes sense, since the multi_pack_index struct already tells us everything we need to access the files in its associated object directory. Signed-off-by: Jeff King <peff@peff.net> Reviewed-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Sep 9, 2021 at 15:56 UTC
bfbb60d328426f0fcc708e2da13d0063ba63e9db
3 files changed
+3
-5
midx.c
+1
-1
@@ -1144,7 +1144,7 @@ static int write_midx_internal(const char *object_dir,
1144
int bitmap_exists;
1145
int want_bitmap = flags & MIDX_WRITE_BITMAP;
1146
1147
- bitmap_git = prepare_midx_bitmap_git(the_repository, ctx.m);
1147
+ bitmap_git = prepare_midx_bitmap_git(ctx.m);
1148
bitmap_exists = bitmap_git && bitmap_is_midx(bitmap_git);
1149
free_bitmap_index(bitmap_git);
1150
pack-bitmap.c
+1
-2
@@ -517,8 +517,7 @@ struct bitmap_index *prepare_bitmap_git(struct repository *r)
517
return NULL;
518
}
519
520
-struct bitmap_index *prepare_midx_bitmap_git(struct repository *r,
521
- struct multi_pack_index *midx)
520
+struct bitmap_index *prepare_midx_bitmap_git(struct multi_pack_index *midx)
521
{
522
struct bitmap_index *bitmap_git = xcalloc(1, sizeof(*bitmap_git));
523
pack-bitmap.h
+1
-2
@@ -44,8 +44,7 @@ typedef int (*show_reachable_fn)(
44
struct bitmap_index;
45
46
struct bitmap_index *prepare_bitmap_git(struct repository *r);
47
-struct bitmap_index *prepare_midx_bitmap_git(struct repository *r,
48
- struct multi_pack_index *midx);
47
+struct bitmap_index *prepare_midx_bitmap_git(struct multi_pack_index *midx);
48
void count_bitmap_commit_list(struct bitmap_index *, uint32_t *commits,
49
uint32_t *trees, uint32_t *blobs, uint32_t *tags);
50
void traverse_bitmap_commit_list(struct bitmap_index *,