@matheusbsbs / matheus-bagliano / commits / bfbfc9a953

send-email: Net::SMTP::starttls was introduced in v2.34

We cannot rely on the starttls method being present in Net::SMTP until c274b798e6881a941d941808c6d89966975cb8c8 (Merge branch 'ipv6_ssl' of https://github.com/noxxi/perl-libnet into noxxi-ipv6_ssl, 2014-06-02), which set the module version to 2.34. This version was first shipped as part of perl in v5.21.5~169 (Update libnet to CPAN version 3.01, 2014-10-10). Noticed on an Ubuntu system with perl 5.18.2-2ubuntu1.1, which provides Net::SMTP version 2.31. The error message is Can't locate object method "starttls" via package "Net::SMTP" at /usr/lib/git-core/git-send-email line 1410. Reported-by: Brandon Williams <bmwill@google.com> Reported-and-tested-by: Eric Biggers <ebiggers3@gmail.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jonathan Nieder committed May 31, 2017 at 17:17 UTC bfbfc9a953d8e26b029110c05581b22f9f0d77e9

1 file changed +1 -1

git-send-email.perl

+1 -1

@@ -1354,7 +1354,7 @@ EOF

1354 }

1355

1356 require Net::SMTP;

1357 - my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("1.28");

1357 + my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("2.34");

1358 $smtp_domain ||= maildomain();

1359

1360 if ($smtp_encryption eq 'ssl') {