name-rev: drop unused parameters from is_better_name()
When this function was extracted in 0041bf6544 (name-rev: refactor logic to see if a new candidate is a better name, 2017-03-29), it ended up getting more arguments than it needs. It's possible we may later use these values to evaluate the name, but since it's a static function with a single caller, it will be easy to add them back then. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
May 9, 2019 at 17:30 UTC
c0165798952fff060243cdf199df30209f9995bc
1 file changed
+1
-4
builtin/name-rev.c
+1
-4
@@ -40,9 +40,7 @@ static void set_commit_rev_name(struct commit *commit, struct rev_name *name)
40
}
41
42
static int is_better_name(struct rev_name *name,
43
- const char *tip_name,
43
timestamp_t taggerdate,
45
- int generation,
44
int distance,
45
int from_tag)
46
{
@@ -103,8 +101,7 @@ static void name_rev(struct commit *commit,
101
name = xmalloc(sizeof(rev_name));
102
set_commit_rev_name(commit, name);
103
goto copy_data;
106
- } else if (is_better_name(name, tip_name, taggerdate,
107
- generation, distance, from_tag)) {
104
+ } else if (is_better_name(name, taggerdate, distance, from_tag)) {
105
copy_data:
106
name->tip_name = tip_name;
107
name->taggerdate = taggerdate;