avoid using skip_prefix as a boolean
There's no point in using: if (skip_prefix(buf, "foo")) over if (starts_with(buf, "foo")) as the point of skip_prefix is to return a pointer to the data after the prefix. Using starts_with is more readable, and will make refactoring skip_prefix easier. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jun 18, 2014 at 15:42 UTC
c0264180d74510669bcec9bb5ff12a145c685b8e
1 file changed
+1
-1
builtin/fmt-merge-msg.c
+1
-1
@@ -298,7 +298,7 @@ static void credit_people(struct strbuf *out,
298
(them->nr == 1 &&
299
me &&
300
(me = skip_prefix(me, them->items->string)) != NULL &&
301
- skip_prefix(me, " <")))
301
+ starts_with(me, " <")))
302
return;
303
strbuf_addf(out, "\n%c %s ", comment_line_char, label);
304
add_people_count(out, them);