@matheusbsbs / matheus-bagliano / commits / c0eedbc009

test-lib: remove check_var_migration

Remove the check_var_migration() migration helper. This was added back in [1], [2] and [3] to warn users to migrate from e.g. the "GIT_FSMONITOR_TEST" name to "GIT_TEST_FSMONITOR". I daresay that having been warning about this since late 2018 (or v2.20.0) was sufficient time to give everyone interested a heads-up about moving to the new names. I don't see the need for going through the "do this later" codepath anticipated in [1], let's just remove this instead. 1. 4cb54d0aa8e (fsmonitor: update GIT_TEST_FSMONITOR support, 2018-09-18) 2. 1f357b045b5 (read-cache: update TEST_GIT_INDEX_VERSION support, 2018-09-18) 3. 5765d97b71d (preload-index: update GIT_FORCE_PRELOAD_TEST support, 2018-09-18) Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed Feb 9, 2021 at 22:41 UTC c0eedbc009d9587602bfb2057158c102a88acf3f

1 file changed -30

t/test-lib.sh

-30

@@ -462,36 +462,6 @@ export GIT_DEFAULT_HASH

462 GIT_TRACE_BARE=1

463 export GIT_TRACE_BARE

464

465 -check_var_migration () {

466 - # the warnings and hints given from this helper depends

467 - # on end-user settings, which will disrupt the self-test

468 - # done on the test framework itself.

469 - case "$GIT_TEST_FRAMEWORK_SELFTEST" in

470 - t) return ;;

471 - esac

472 -

473 - old_name=$1 new_name=$2

474 - eval "old_isset=\${${old_name}:+isset}"

475 - eval "new_isset=\${${new_name}:+isset}"

476 -

477 - case "$old_isset,$new_isset" in

478 - isset,)

479 - echo >&2 "warning: $old_name is now $new_name"

480 - echo >&2 "hint: set $new_name too during the transition period"

481 - eval "$new_name=\$$old_name"

482 - ;;

483 - isset,isset)

484 - # do this later

485 - # echo >&2 "warning: $old_name is now $new_name"

486 - # echo >&2 "hint: remove $old_name"

487 - ;;

488 - esac

489 -}

490 -

491 -check_var_migration GIT_FSMONITOR_TEST GIT_TEST_FSMONITOR

492 -check_var_migration TEST_GIT_INDEX_VERSION GIT_TEST_INDEX_VERSION

493 -check_var_migration GIT_FORCE_PRELOAD_TEST GIT_TEST_PRELOAD_INDEX

494 -

465 # Use specific version of the index file format

466 if test -n "${GIT_TEST_INDEX_VERSION:+isset}"

467 then