Documentation/SubmittingPatches: What's Acked-by and Tested-by?
We used to talk about "internal company procedures", but this document is about submitting patches to the git mailing list. More useful information is when to say Acked-by: and Tested-by:. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Feb 3, 2008 at 17:02 UTC
c11c3b56818bcaf1acea6cb2a9a68fbca644f968
1 file changed
+12
-4
Documentation/SubmittingPatches
+12
-4
@@ -216,10 +216,18 @@ then you just add a line saying
216
This line can be automatically added by git if you run the git-commit
217
command with the -s option.
218
219
-Some people also put extra tags at the end. They'll just be ignored for
220
-now, but you can do this to mark internal company procedures or just
221
-point out some special detail about the sign-off.
222
-
219
+Notice that you can place your own Signed-off-by: line when
220
+forwarding somebody else's patch with the above rules for
221
+D-C-O. Indeed you are encouraged to do so. Do not forget to
222
+place an in-body "From: " line at the beginning to properly attribute
223
+the change to its true author (see (2) above).
224
+
225
+Some people also put extra tags at the end.
226
+
227
+"Acked-by:" says that the patch was reviewed by the person who
228
+is more familiar with the issues and the area the patch attempts
229
+to modify. "Tested-by:" says the patch was tested by the person
230
+and found to have the desired effect.
231
232
------------------------------------------------
233
MUA specific hints