@matheusbsbs / matheus-bagliano / commits / c1f8064b14
Fork 0

Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used.

Before this patch, -DDEFAULT_GIT_TEMPLATE_DIR was passed on compilation command line to all and every .c file compiled. In fact the macro is used by only one .c file, and unused by all other .c files. Remove -DDEFAULT_GIT_TEMPLATE_DIR where unused. Follow the example of exec_cmd.o. Pass -DDEFAULT_GIT_TEMPLATE_DIR only where actually used. Signed-off-by: Yakov Lerner <iler.ml@gmail.com> Signed-off-by: Junio C Hamano <junkio@cox.net>

Yakov Lerner committed Jun 22, 2006 at 04:47 UTC c1f8064b143f98e8b3c5ff1ce12ebd0800df5d67
1 file changed +2 -1
Makefile
+2 -1
@@ -472,7 +472,6 @@ PYTHON_PATH_SQ = $(subst ','\'',$(PYTHON_PATH))
472 GIT_PYTHON_DIR_SQ = $(subst ','\'',$(GIT_PYTHON_DIR))
473
474 ALL_CFLAGS += -DSHA1_HEADER='$(SHA1_HEADER_SQ)' $(COMPAT_CFLAGS)
475 -ALL_CFLAGS += -DDEFAULT_GIT_TEMPLATE_DIR='"$(template_dir_SQ)"'
475 LIB_OBJS += $(COMPAT_OBJS)
476 export prefix TAR INSTALL DESTDIR SHELL_PATH template_dir
477 ### Build rules
@@ -548,6 +547,8 @@ git$X git.spec \
547
548 exec_cmd.o: exec_cmd.c GIT-CFLAGS
549 $(CC) -o $*.o -c $(ALL_CFLAGS) '-DGIT_EXEC_PATH="$(gitexecdir_SQ)"' $<
550 +builtin-init-db.o: builtin-init-db.c GIT-CFLAGS
551 + $(CC) -o $*.o -c $(ALL_CFLAGS) -DDEFAULT_GIT_TEMPLATE_DIR='"$(template_dir_SQ)"' $<
552
553 http.o: http.c GIT-CFLAGS
554 $(CC) -o $*.o -c $(ALL_CFLAGS) -DGIT_USER_AGENT='"git/$(GIT_VERSION)"' $<