tests: do not negate test_path_exists
As a way to assert the path 'foo' is missing, "! test_path_exists foo" is a poor way to do so, as the helper is designed to complain when 'foo' is missing, but the intention of the author who used negated form was to make sure it does not exist. This does not help debugging the tests. Use test_path_is_missing instead, which is a more appropriate helper. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
May 15, 2023 at 19:26 UTC
c205923649568dee9c543d5b7f040d2c660a2272
2 files changed
+3
-3
t/t4067-diff-partial-clone.sh
+2
-2
@@ -151,7 +151,7 @@ test_expect_success 'diff does not fetch anything if inexact rename detection is
151
152
# Ensure no fetches.
153
GIT_TRACE_PACKET="$(pwd)/trace" git -C client diff --raw -M HEAD^ HEAD &&
154
- ! test_path_exists trace
154
+ test_path_is_missing trace
155
'
156
157
test_expect_success 'diff --break-rewrites fetches only if necessary, and batches blobs if it does' '
@@ -171,7 +171,7 @@ test_expect_success 'diff --break-rewrites fetches only if necessary, and batche
171
172
# Ensure no fetches.
173
GIT_TRACE_PACKET="$(pwd)/trace" git -C client diff --raw -M HEAD^ HEAD &&
174
- ! test_path_exists trace &&
174
+ test_path_is_missing trace &&
175
176
# But with --break-rewrites, ensure that there is exactly 1 negotiation
177
# by checking that there is only 1 "done" line sent. ("done" marks the
t/t4115-apply-symlink.sh
+1
-1
@@ -74,7 +74,7 @@ test_expect_success SYMLINKS 'symlink escape when creating new files' '
74
error: affected file ${SQ}renamed-symlink/create-me${SQ} is beyond a symbolic link
75
EOF
76
test_cmp expected_stderr stderr &&
77
- ! test_path_exists .git/create-me
77
+ test_path_is_missing .git/create-me
78
'
79
80
test_expect_success SYMLINKS 'symlink escape when modifying file' '