t1450: use "mv -f" within loose object directory
The loose objects are created with mode 0444. That doesn't prevent them being overwritten by rename(), but some versions of "mv" will be extra careful and prompt the user, even without "-i". Reportedly macOS does this, at least in the Travis builds. The prompt reads from /dev/null, defaulting to "no", and the object isn't moved. Then to make matters even more interesting, it still returns "0" and the rest of the test proceeds, but with a broken setup. We can work around it by using "mv -f" to override the prompt. This should work as it's already used in t5504 for the same purpose. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jan 24, 2017 at 08:27 UTC
c20d4d702f13e6bd4e4c8757989bed62a75e2cfa
1 file changed
+1
-1
t/t1450-fsck.sh
+1
-1
@@ -536,7 +536,7 @@ test_expect_success 'fsck --connectivity-only' '
536
# free to examine the type if it chooses.
537
empty=.git/objects/e6/9de29bb2d1d6434b8b29ae775ad8c2e48c5391 &&
538
blob=$(echo unrelated | git hash-object -w --stdin) &&
539
- mv $(sha1_file $blob) $empty &&
539
+ mv -f $(sha1_file $blob) $empty &&
540
541
test_must_fail git fsck --strict &&
542
git fsck --strict --connectivity-only &&