receive-pack: lowercase error messages
Documentation/CodingGuidelines says “do not end error messages with a full stop” and “do not capitalize the first word”. Clean up existing messages, some of which we will be touching in later steps in the series, that deviate from these rules in this file, as a preparation for the main part of the topic. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Anders Kaseorg committed
Dec 1, 2021 at 14:15 UTC
c25edee9a5dd9481e00ee5d2d40d4b9f8231993f
2 files changed
+6
-6
builtin/receive-pack.c
+5
-5
@@ -175,7 +175,7 @@ static int receive_pack_config(const char *var, const char *value, void *cb)
175
strbuf_addf(&fsck_msg_types, "%c%s=%s",
176
fsck_msg_types.len ? ',' : '=', var, value);
177
else
178
- warning("Skipping unknown msg id '%s'", var);
178
+ warning("skipping unknown msg id '%s'", var);
179
return 0;
180
}
181
@@ -1589,9 +1589,9 @@ static const char *update(struct command *cmd, struct shallow_info *si)
1589
if (!parse_object(the_repository, old_oid)) {
1590
old_oid = NULL;
1591
if (ref_exists(name)) {
1592
- rp_warning("Allowing deletion of corrupt ref.");
1592
+ rp_warning("allowing deletion of corrupt ref");
1593
} else {
1594
- rp_warning("Deleting a non-existent ref.");
1594
+ rp_warning("deleting a non-existent ref");
1595
cmd->did_not_exist = 1;
1596
}
1597
}
@@ -2490,9 +2490,9 @@ int cmd_receive_pack(int argc, const char **argv, const char *prefix)
2490
argc = parse_options(argc, argv, prefix, options, receive_pack_usage, 0);
2491
2492
if (argc > 1)
2493
- usage_msg_opt(_("Too many arguments."), receive_pack_usage, options);
2493
+ usage_msg_opt(_("too many arguments"), receive_pack_usage, options);
2494
if (argc == 0)
2495
- usage_msg_opt(_("You must specify a directory."), receive_pack_usage, options);
2495
+ usage_msg_opt(_("you must specify a directory"), receive_pack_usage, options);
2496
2497
service_dir = argv[0];
2498
t/t5504-fetch-receive-strict.sh
+1
-1
@@ -292,7 +292,7 @@ test_expect_success 'push with receive.fsck.missingEmail=warn' '
292
receive.fsck.missingEmail warn &&
293
git push --porcelain dst bogus >act 2>&1 &&
294
grep "missingEmail" act &&
295
- test_i18ngrep "Skipping unknown msg id.*whatever" act &&
295
+ test_i18ngrep "skipping unknown msg id.*whatever" act &&
296
git --git-dir=dst/.git branch -D bogus &&
297
git --git-dir=dst/.git config --add \
298
receive.fsck.missingEmail ignore &&