What's cooking (2024/08 #07)
Junio C Hamano committed
Aug 19, 2024 at 15:42 UTC
c2ddd02d6ba655a91494f665033de5b86cf75d6e
1 file changed
+282
-313
whats-cooking.txt
+282
-313
@@ -1,10 +1,10 @@
1
To: git@vger.kernel.org
2
-Subject: What's cooking in git.git (Aug 2024, #06; Fri, 16)
3
-X-master-at: 87a1768b93a67d0420255a43d9e07387b2e805ad
4
-X-next-at: a157f53b32d1635eb6dc54bf001924b543cd6568
2
+Subject: What's cooking in git.git (Aug 2024, #07; Mon, 19)
3
+X-master-at: bb9c16bd4f1a9a00799e10c81ee6506cf468c0c7
4
+X-next-at: 58194ef3dc4e17ce4fbb862d7d4cc852f9f686ad
5
Bcc: lwn@lwn.net, gitster@pobox.com
6
7
-What's cooking in git.git (Aug 2024, #06; Fri, 16)
7
+What's cooking in git.git (Aug 2024, #07; Mon, 19)
8
--------------------------------------------------
9
10
Here are the topics that have been cooking in my tree. Commits
@@ -17,6 +17,18 @@ topic without enough support may be discarded after a long period of
17
no activity (of course they can be resubmit when new interests
18
arise).
19
20
+A handful of "safe" topics that have been in 'master' are merged on
21
+top of v2.46.0 on the 'maint' branch, which may become part of Git
22
+2.46.1 if we decide that we need such an maintenance update. The
23
+fixes currently there are small enough that the do not warrant an
24
+immediate release of such a maintenance update, though.
25
+
26
+Among the topics that were sent to the list but not in 'next', there
27
+are a few (conceptual) biggies like the Rust binding, clar unit test
28
+framework, and documentation mark-up with s:[], that may need
29
+further discussion. There also are topics that are not covered well
30
+by reviewers (yet).
31
+
32
Copies of the source code to Git live in many repositories, and the
33
following is a list of the ones I push into or their mirrors. Some
34
repositories have only a subset of branches.
@@ -46,127 +58,168 @@ Release tarballs are available at:
58
https://www.kernel.org/pub/software/scm/git/
59
60
--------------------------------------------------
49
-[Graduated to 'master']
61
+[New Topics]
62
51
-* ag/t7004-modernize (2024-08-08) 8 commits
52
- (merged to 'next' on 2024-08-09 at 7bce577df4)
53
- + t7004: make use of write_script
54
- + t7004: use single quotes instead of double quotes
55
- + t7004: begin the test body on the same line as test_expect_success
56
- + t7004: description on the same line as test_expect_success
57
- + t7004: do not prepare things outside test_expect_success
58
- + t7004: use indented here-doc
59
- + t7004: one command per line
60
- + t7004: remove space after redirect operators
63
+* jk/mark-unused-parameters (2024-08-17) 15 commits
64
+ (merged to 'next' on 2024-08-19 at f85d6096c9)
65
+ + scalar: mark unused parameters in dummy function
66
+ + daemon: mark unused parameters in non-posix fallbacks
67
+ + setup: mark unused parameter in config callback
68
+ + test-mergesort: mark unused parameters in trivial callback
69
+ + t-hashmap: mark unused parameters in callback function
70
+ + reftable: mark unused parameters in virtual functions
71
+ + reftable: drop obsolete test function declarations
72
+ + reftable: ignore unused argc/argv in test functions
73
+ + unit-tests: ignore unused argc/argv
74
+ + t/helper: mark more unused argv/argc arguments
75
+ + oss-fuzz: mark unused argv/argc argument
76
+ + refs: mark unused parameters in do_for_each_reflog_helper()
77
+ + refs: mark unused parameters in ref_store fsck callbacks
78
+ + update-ref: mark more unused parameters in parser callbacks
79
+ + imap-send: mark unused parameter in ssl_socket_connect() fallback
80
+
81
+ Mark unused parameters as UNUSED to squelch -Wunused warnings.
82
+
83
+ Will merge to 'master'.
84
+ source: <20240817082101.GA6761@coredump.intra.peff.net>
85
62
- Coding style fixes to a test script.
63
- source: <20240808163302.17521-1-abdobngad@gmail.com>
86
87
+* jk/drop-unused-parameters (2024-08-17) 5 commits
88
+ (merged to 'next' on 2024-08-19 at f5c703013d)
89
+ + diff-lib: drop unused index argument from get_stat_data()
90
+ + ref-filter: drop unused parameters from email_atom_option_parser()
91
+ + pack-bitmap: drop unused parameters from select_pseudo_merges()
92
+ + pack-bitmap: load writer config from repository parameter
93
+ + refs: drop some unused parameters from create_symref_lock()
94
66
-* es/doc-platform-support-policy (2024-08-02) 1 commit
67
- (merged to 'next' on 2024-08-09 at 110c94ea82)
68
- + Documentation: add platform support policy
95
+ Drop unused parameters from functions.
96
70
- A policy document that describes platform support levels and
71
- expectation on platform stakeholders has been introduced.
72
- source: <20240802221948.2367124-1-emilyshaffer@google.com>
97
+ Will merge to 'master'.
98
+ source: <20240817072621.GA1535666@coredump.intra.peff.net>
99
100
75
-* gt/unit-test-hashmap (2024-08-06) 1 commit
76
- (merged to 'next' on 2024-08-09 at e62febfb4e)
77
- + t: port helper/test-hashmap.c to unit-tests/t-hashmap.c
101
+* ps/maintenance-detach-fix-more (2024-08-19) 3 commits
102
+ - builtin/maintenance: fix loose objects task emitting pack hash
103
+ - t7900: exercise detaching via trace2 regions
104
+ - t7900: fix flaky test due to leaking background job
105
+ (this branch uses ps/maintenance-detach-fix.)
106
79
- An existing test of hashmap API has been rewritten with the
80
- unit-test framework.
81
- cf. <CAP8UFD04uQbWhY0QDp+nC8VyBvpUs=tBDm=w4CzKK2GcwFZdGQ@mail.gmail.com>
82
- source: <20240803133517.73308-2-shyamthakkar001@gmail.com>
107
+ A tests for "git maintenance" that were broken on Windows have been
108
+ corrected.
109
110
+ Expecting a (hopefully small and final) reroll.
111
+ cf. <ZsMIxmX2Ash9YtEU@tanuki>
112
+ source: <cover.1724053639.git.ps@pks.im>
113
85
-* jc/refs-symref-referent (2024-08-09) 3 commits
86
- (merged to 'next' on 2024-08-09 at 3183f3d05b)
87
- + ref-filter: populate symref from iterator
88
- + refs: add referent to each_ref_fn
89
- + refs: keep track of unresolved reference value in iterators
114
91
- The refs API has been taught to give symref target information to
92
- the users of ref iterators, allowing for-each-ref and friends to
93
- avoid an extra ref_resolve_* API call per a symbolic ref.
94
- source: <pull.1712.v4.git.git.1723217871.gitgitgadget@gmail.com>
115
+* ps/reftable-concurrent-compaction (2024-08-19) 10 commits
116
+ - reftable/stack: fix segfault when reload with reused readers fails
117
+ - reftable/stack: reorder swapping in the reloaded stack contents
118
+ - reftable/reader: keep readers alive during iteration
119
+ - reftable/reader: introduce refcounting
120
+ - reftable/stack: fix broken refnames in `write_n_ref_tables()`
121
+ - reftable/reader: inline `reader_close()`
122
+ - reftable/reader: inline `init_reader()`
123
+ - reftable/reader: rename `reftable_new_reader()`
124
+ - reftable/stack: inline `stack_compact_range_stats()`
125
+ - reftable/blocksource: drop malloc block source
126
+ (this branch uses ps/reftable-drop-generic.)
127
128
+ source: <cover.1723640107.git.ps@pks.im>
129
+ source: <cover.1724080006.git.ps@pks.im>
130
+
131
+--------------------------------------------------
132
+[Graduated to 'master']
133
+
134
+* jc/tests-no-useless-tee (2024-08-08) 1 commit
135
+ (merged to 'next' on 2024-08-12 at 188e777e16)
136
+ + tests: drop use of 'tee' that hides exit status
137
97
-* jc/safe-directory (2024-07-30) 4 commits
98
- (merged to 'next' on 2024-08-05 at 77aa0f1d08)
99
- + safe.directory: setting safe.directory="." allows the "current" directory
100
- + safe.directory: normalize the configured path
101
- + safe.directory: normalize the checked path
102
- + safe.directory: preliminary clean-up
138
+ Test fixes.
139
+ source: <xmqq4j7uhfvm.fsf@gitster.g>
140
104
- Follow-up on 2.45.1 regression fix.
105
- source: <20240730184352.2503276-1-gitster@pobox.com>
141
142
+* ps/transport-leakfix-test-updates (2024-08-08) 1 commit
143
+ (merged to 'next' on 2024-08-12 at ee80dbc4f6)
144
+ + transport: mark more tests leak-free
145
108
-* jc/t3206-test-when-finished-fix (2024-08-06) 1 commit
109
- (merged to 'next' on 2024-08-08 at 46461db3a2)
110
- + t3206: test_when_finished before dirtying operations, not after
146
+ Test updates.
147
+ source: <ZrRV_HrUArsvRgn8@tanuki>
148
112
- Test clean-up.
113
- source: <xmqqwmkttwfm.fsf@gitster.g>
149
150
+* rs/unit-tests-test-run (2024-07-30) 6 commits
151
+ (merged to 'next' on 2024-08-12 at 9df4336877)
152
+ + t-strvec: use if_test
153
+ + t-reftable-basics: use if_test
154
+ + t-ctype: use if_test
155
+ + unit-tests: add if_test
156
+ + unit-tests: show location of checks outside of tests
157
+ + t0080: use here-doc test body
158
116
-* ps/reftable-stack-compaction (2024-08-08) 9 commits
117
- (merged to 'next' on 2024-08-09 at d7875bf14b)
118
- + reftable/stack: handle locked tables during auto-compaction
119
- + reftable/stack: fix corruption on concurrent compaction
120
- + reftable/stack: use lock_file when adding table to "tables.list"
121
- + reftable/stack: do not die when fsyncing lock file files
122
- + reftable/stack: simplify tracking of table locks
123
- + reftable/stack: update stats on failed full compaction
124
- + reftable/stack: test compaction with already-locked tables
125
- + reftable/stack: extract function to setup stack with N tables
126
- + reftable/stack: refactor function to gather table sizes
127
- (this branch is used by ps/reftable-drop-generic.)
159
+ Unit-test framework has learned a simple control structure to allow
160
+ embedding test statements in-line instead of having to create a new
161
+ function to contain them.
162
+ source: <077a178e-eb30-45ff-b653-a514bfd33077@web.de>
163
129
- The code paths to compact multiple reftable files have been updated
130
- to correctly deal with multiple compaction triggering at the same
131
- time.
132
- source: <cover.1723123606.git.ps@pks.im>
164
165
+* sj/ref-fsck (2024-08-08) 9 commits
166
+ (merged to 'next' on 2024-08-09 at 3bde10da94)
167
+ + fsck: add ref name check for files backend
168
+ + files-backend: add unified interface for refs scanning
169
+ + builtin/refs: add verify subcommand
170
+ + refs: set up ref consistency check infrastructure
171
+ + fsck: add refs report function
172
+ + fsck: add a unified interface for reporting fsck messages
173
+ + fsck: make "fsck_error" callback generic
174
+ + fsck: rename objects-related fsck error functions
175
+ + fsck: rename "skiplist" to "skip_oids"
176
135
-* ps/submodule-ref-format (2024-08-08) 8 commits
136
- (merged to 'next' on 2024-08-09 at 2b17964809)
137
- + object: fix leaking packfiles when closing object store
138
- + submodule: fix leaking seen submodule names
139
- + submodule: fix leaking fetch tasks
140
- + builtin/submodule: allow "add" to use different ref storage format
141
- + refs: fix ref storage format for submodule ref stores
142
- + builtin/clone: propagate ref storage format to submodules
143
- + builtin/submodule: allow cloning with different ref storage format
144
- + git-submodule.sh: break overly long command lines
177
+ "git fsck" infrastructure has been taught to also check the sanity
178
+ of the ref database, in addition to the object database.
179
+ source: <ZrSqMmD-quQ18a9F@ArchLinux.localdomain>
180
146
- Support to specify ref backend for submodules has been enhanced.
147
- source: <cover.1723102259.git.ps@pks.im>
181
182
+* tb/incremental-midx-part-1 (2024-08-06) 19 commits
183
+ (merged to 'next' on 2024-08-12 at 92ec55fd49)
184
+ + midx: implement support for writing incremental MIDX chains
185
+ + t/t5313-pack-bounds-checks.sh: prepare for sub-directories
186
+ + t: retire 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP'
187
+ + midx: implement verification support for incremental MIDXs
188
+ + midx: support reading incremental MIDX chains
189
+ + midx: teach `midx_fanout_add_midx_fanout()` about incremental MIDXs
190
+ + midx: teach `midx_preferred_pack()` about incremental MIDXs
191
+ + midx: teach `midx_contains_pack()` about incremental MIDXs
192
+ + midx: remove unused `midx_locate_pack()`
193
+ + midx: teach `fill_midx_entry()` about incremental MIDXs
194
+ + midx: teach `nth_midxed_offset()` about incremental MIDXs
195
+ + midx: teach `bsearch_midx()` about incremental MIDXs
196
+ + midx: introduce `bsearch_one_midx()`
197
+ + midx: teach `nth_bitmapped_pack()` about incremental MIDXs
198
+ + midx: teach `nth_midxed_object_oid()` about incremental MIDXs
199
+ + midx: teach `prepare_midx_pack()` about incremental MIDXs
200
+ + midx: teach `nth_midxed_pack_int_id()` about incremental MIDXs
201
+ + midx: add new fields for incremental MIDX chains
202
+ + Documentation: describe incremental MIDX format
203
+ (this branch is used by jk/midx-unused-fix and tb/incremental-midx-part-2.)
204
150
-* rs/t-example-simplify (2024-07-30) 1 commit
151
- (merged to 'next' on 2024-08-08 at edeb01c38e)
152
- + t-example-decorate: remove test messages
205
+ Incremental updates of multi-pack index files.
206
+ source: <cover.1722958595.git.me@ttaylorr.com>
207
154
- Unit test simplification.
155
- source: <5c838884-b606-465a-8f7e-ab760ddadef8@web.de>
208
+--------------------------------------------------
209
+[Stalled]
210
211
+* pp/add-parse-range-unit-test (2024-05-27) 1 commit
212
+ - apply: add unit tests for parse_range
213
158
-* xx/diff-tree-remerge-diff-fix (2024-08-09) 1 commit
159
- (merged to 'next' on 2024-08-09 at cabe67c0d1)
160
- + diff-tree: fix crash when used with --remerge-diff
161
- (this branch is used by jc/range-diff-lazy-setup.)
214
+ A unit test for code that parses the hunk offset and length from a
215
+ patch fragment header as been added.
216
163
- "git rev-list ... | git diff-tree -p --remerge-diff --stdin" should
164
- behave more or less like "git log -p --remerge-diff" but instead it
165
- crashed, forgetting to prepare a temporary object store needed.
166
- source: <pull.1771.v2.git.1723188292498.gitgitgadget@gmail.com>
217
+ Expecting a reroll.
218
+ cf. <b7eca313-9ea8-4132-ba1d-ed9236e07095@gmail.com>
219
+ source: <pull.1677.v2.git.git.1716710073910.gitgitgadget@gmail.com>
220
221
--------------------------------------------------
169
-[New Topics]
222
+[Cooking]
223
224
* jc/how-to-maintain-updates (2024-08-14) 1 commit
225
(merged to 'next' on 2024-08-15 at 20ebc08e74)
@@ -178,7 +231,7 @@ Release tarballs are available at:
231
source: <xmqqikw2wvup.fsf@gitster.g>
232
233
181
-* ah/git-prompt-portability (2024-08-15) 8 commits
234
+* ah/git-prompt-portability (2024-08-17) 8 commits
235
- git-prompt: support custom 0-width PS1 markers
236
- git-prompt: ta-da! document usage in other shells
237
- git-prompt: don't use shell $'...'
@@ -192,7 +245,7 @@ Release tarballs are available at:
245
which has been corrected to work with more shells.
246
247
Will merge to 'next'?
195
- source: <pull.1750.v2.git.git.1723727653.gitgitgadget@gmail.com>
248
+ source: <pull.1750.v3.git.git.1723886760.gitgitgadget@gmail.com>
249
250
251
* jk/apply-patch-mode-check-fix (2024-08-15) 1 commit
@@ -222,6 +275,7 @@ Release tarballs are available at:
275
- reftable/merged: rename `reftable_new_merged_table()`
276
- reftable/merged: expose functions to initialize iterators
277
- Merge branch 'ps/reftable-stack-compaction' into ps/reftable-drop-generic
278
+ (this branch is used by ps/reftable-concurrent-compaction.)
279
280
The code in the reftable library has been cleaned up by discarding
281
unused "generic" interface.
@@ -231,37 +285,40 @@ Release tarballs are available at:
285
286
287
* ps/hash-and-ref-format-from-config (2024-08-16) 5 commits
234
- - setup: make ref storage format configurable via config
235
- - setup: make object format configurable via config
236
- - setup: merge configuration of repository formats
237
- - t0001: delete repositories when object format tests finish
238
- - t0001: exercise initialization with ref formats more thoroughly
288
+ (merged to 'next' on 2024-08-16 at 2028c02d01)
289
+ + setup: make ref storage format configurable via config
290
+ + setup: make object format configurable via config
291
+ + setup: merge configuration of repository formats
292
+ + t0001: delete repositories when object format tests finish
293
+ + t0001: exercise initialization with ref formats more thoroughly
294
295
The default object hash and ref backend format used to be settable
296
only with explicit command line option to "git init" and
297
environment variables, but now they can be configured in the user's
298
global and system wide configuration.
299
245
- Will merge to 'next'.
300
+ Will merge to 'master'.
301
source: <cover.1723798388.git.ps@pks.im>
302
303
304
* tb/pseudo-merge-bitmap-fixes (2024-08-15) 8 commits
250
- - pseudo-merge.c: ensure pseudo-merge groups are closed
251
- - pseudo-merge.c: do not generate empty pseudo-merge commits
252
- - t/t5333-pseudo-merge-bitmaps.sh: demonstrate empty pseudo-merge groups
253
- - pack-bitmap-write.c: select pseudo-merges even for small bitmaps
254
- - pack-bitmap: drop redundant args from `bitmap_writer_finish()`
255
- - pack-bitmap: drop redundant args from `bitmap_writer_build()`
256
- - pack-bitmap: drop redundant args from `bitmap_writer_build_type_index()`
257
- - pack-bitmap: initialize `bitmap_writer_init()` with packing_data
305
+ (merged to 'next' on 2024-08-19 at 10cc82b2fb)
306
+ + pseudo-merge.c: ensure pseudo-merge groups are closed
307
+ + pseudo-merge.c: do not generate empty pseudo-merge commits
308
+ + t/t5333-pseudo-merge-bitmaps.sh: demonstrate empty pseudo-merge groups
309
+ + pack-bitmap-write.c: select pseudo-merges even for small bitmaps
310
+ + pack-bitmap: drop redundant args from `bitmap_writer_finish()`
311
+ + pack-bitmap: drop redundant args from `bitmap_writer_build()`
312
+ + pack-bitmap: drop redundant args from `bitmap_writer_build_type_index()`
313
+ + pack-bitmap: initialize `bitmap_writer_init()` with packing_data
314
(this branch is used by tb/incremental-midx-part-2.)
315
316
We created a useless pseudo-merge reachability bitmap that is about
317
0 commits, and attempted to include commits that are not in packs,
318
which made no sense. These bugs have been corrected.
319
264
- Will merge to 'next'.
320
+ Will merge to 'master'.
321
+ cf. <20240817104412.GE551779@coredump.intra.peff.net>
322
source: <cover.1723743050.git.me@ttaylorr.com>
323
324
@@ -281,65 +338,51 @@ Release tarballs are available at:
338
- Documentation: describe incremental MIDX bitmaps
339
- Merge branch 'tb/pseudo-merge-bitmap-fixes' into tb/incremental-midx-part-2
340
- Merge branch 'tb/incremental-midx-part-1' into tb/incremental-midx-part-2
284
- (this branch uses tb/incremental-midx-part-1 and tb/pseudo-merge-bitmap-fixes.)
341
+ (this branch uses tb/pseudo-merge-bitmap-fixes.)
342
343
Incremental updates of multi-pack index files.
344
345
+ Needs review.
346
source: <cover.1723760847.git.me@ttaylorr.com>
347
348
291
-* mt/rebase-x-quiet (2024-08-15) 1 commit
349
+* mt/rebase-x-quiet (2024-08-16) 1 commit
350
- rebase -x: don't print "Executing:" msgs with --quiet
351
352
"git rebase -x --quiet" was not quiet, which was corrected.
353
354
Expecting a reroll.
297
- cf. <Zr8NOh-gMuhp-p0M@tanuki>
298
- source: <767ea219e3365303535c8b5f0d8eadb28b5e872e.1723778779.git.matheus.tavb@gmail.com>
355
+ source: <be3c968b0d9085843cd9ce67e85aadfaaafa69c8.1723848510.git.matheus.tavb@gmail.com>
356
357
301
-* ps/stash-keep-unrack-empty-fix (2024-08-16) 1 commit
302
- - builtin/stash: fix `--keep-index --include-untracked` with empty HEAD
358
+* ps/stash-keep-untrack-empty-fix (2024-08-16) 1 commit
359
+ (merged to 'next' on 2024-08-16 at 3db6b6a815)
360
+ + builtin/stash: fix `--keep-index --include-untracked` with empty HEAD
361
362
A corner case bug in "git stash" was fixed.
363
306
- Will merge to 'next'.
364
+ Will merge to 'master'.
365
source: <6067675b5edf36e2eb28e98119a1c02d0a7ae670.1723804926.git.ps@pks.im>
366
309
---------------------------------------------------
310
-[Stalled]
311
-
312
-* pp/add-parse-range-unit-test (2024-05-27) 1 commit
313
- - apply: add unit tests for parse_range
314
-
315
- A unit test for code that parses the hunk offset and length from a
316
- patch fragment header as been added.
317
-
318
- Expecting a reroll.
319
- cf. <b7eca313-9ea8-4132-ba1d-ed9236e07095@gmail.com>
320
- source: <pull.1677.v2.git.git.1716710073910.gitgitgadget@gmail.com>
321
-
322
---------------------------------------------------
323
-[Cooking]
367
368
* gt/unit-test-urlmatch-normalization (2024-08-14) 1 commit
369
- t: migrate t0110-urlmatch-normalization to the new framework
370
371
Another rewrite of test.
372
330
- Comments?
373
+ Expecting a (hopefully small and final) reroll.
374
+ cf. <CAP8UFD2-VbyK-ZecDKEvgKicWrVe=e=z6mH_xjmrf=a4ZAYd8w@mail.gmail.com>
375
source: <20240814142057.94671-1-shyamthakkar001@gmail.com>
376
377
378
* jk/midx-unused-fix (2024-08-13) 1 commit
379
(merged to 'next' on 2024-08-14 at 2ec51e52e1)
380
+ midx: drop unused parameters from add_midx_to_chain()
337
- (this branch uses tb/incremental-midx-part-1.)
381
382
Code clean-up in the base topic.
383
384
Will merge to 'master'.
342
- source: <cover.1722958595.git.me@ttaylorr.com>
385
+ source: <20240813050216.GA394231@coredump.intra.peff.net>
386
387
388
* ps/bundle-outside-repo-fix (2024-08-13) 2 commits
@@ -355,80 +398,76 @@ Release tarballs are available at:
398
399
400
* ps/clar-unit-test (2024-08-16) 9 commits
358
- - t/unit-tests: convert ctype tests to use clar
359
- - t/unit-tests: convert strvec tests to use clar
360
- - Makefile: wire up the clar unit testing framework
361
- - Makefile: do not use sparse on third-party sources
362
- - Makefile: make hdr-check depend on generated headers
363
- - Makefile: fix sparse dependency on GENERATED_H
364
- - t/clar: fix compatibility with NonStop
365
- - t: import the clar unit testing framework
366
- - t: do not pass GIT_TEST_OPTS to unit tests with prove
401
+ . t/unit-tests: convert ctype tests to use clar
402
+ . t/unit-tests: convert strvec tests to use clar
403
+ . Makefile: wire up the clar unit testing framework
404
+ . Makefile: do not use sparse on third-party sources
405
+ . Makefile: make hdr-check depend on generated headers
406
+ . Makefile: fix sparse dependency on GENERATED_H
407
+ . t/clar: fix compatibility with NonStop
408
+ . t: import the clar unit testing framework
409
+ . t: do not pass GIT_TEST_OPTS to unit tests with prove
410
411
Import clar unit tests framework libgit2 folks invented for our
412
use.
413
371
- Needs to decide how to fill feature gap with our home-grown one
414
+ Need to decide how to fill feature gap with our home-grown one
415
cf. <b87700d2-0c9a-4d0c-9ee4-e6a91278d596@gmail.com>
416
+ Fails to build on Windows.
417
+ cf. https://github.com/git/git/actions/runs/10424256896/job/28875787680
418
source: <cover.1723791831.git.ps@pks.im>
419
420
421
* ps/maintenance-detach-fix (2024-08-16) 7 commits
377
- - run-command: fix detaching when running auto maintenance
378
- - builtin/maintenance: add a `--detach` flag
379
- - builtin/gc: add a `--detach` flag
380
- - builtin/gc: stop processing log file on signal
381
- - builtin/gc: fix leaking config values
382
- - builtin/gc: refactor to read config into structure
383
- - config: fix constness of out parameter for `git_config_get_expiry()`
422
+ (merged to 'next' on 2024-08-16 at 5db1344236)
423
+ + run-command: fix detaching when running auto maintenance
424
+ + builtin/maintenance: add a `--detach` flag
425
+ + builtin/gc: add a `--detach` flag
426
+ + builtin/gc: stop processing log file on signal
427
+ + builtin/gc: fix leaking config values
428
+ + builtin/gc: refactor to read config into structure
429
+ + config: fix constness of out parameter for `git_config_get_expiry()`
430
+ (this branch is used by ps/maintenance-detach-fix-more.)
431
432
Allow maintance tasks other than "gc" to properly go background
433
when "git maintenance" run them.
434
388
- Will merge to 'next'.
435
+ Will wait for the other topic and then merge to 'master'.
436
source: <cover.1723804990.git.ps@pks.im>
437
438
392
-* jk/send-email-translate-aliases (2024-08-15) 4 commits
393
- - fixup! send-email: teach git send-email option to translate aliases
394
- - send-email: teach git send-email option to translate aliases
395
- - t9001-send-email.sh: update alias list used for pine test
396
- - t9001-send-email.sh: fix quoting for mailrc --dump-aliases test
439
+* jk/send-email-translate-aliases (2024-08-17) 3 commits
440
+ (merged to 'next' on 2024-08-19 at dd207c3560)
441
+ + send-email: teach git send-email option to translate aliases
442
+ + t9001-send-email.sh: update alias list used for pine test
443
+ + t9001-send-email.sh: fix quoting for mailrc --dump-aliases test
444
445
"git send-email" learned "--translate-aliases" option that reads
446
addresses from the standard input and emits the result of applying
447
aliases on them to the standard output.
448
402
- Will merge to 'next' after squashing the fix in.
449
+ Will merge to 'master'.
450
source: <20240813-jk-translate-alias-send-email-v2-0-912db4eb6846@gmail.com>
451
452
406
-* cp/unit-test-reftable-block (2024-08-14) 10 commits
407
- - t-reftable-block: add tests for index blocks
408
- - t-reftable-block: add tests for obj blocks
409
- - t-reftable-block: add tests for log blocks
410
- - t-reftable-block: remove unnecessary variable 'j'
411
- - t-reftable-block: use xstrfmt() instead of xstrdup()
412
- - t-reftable-block: use block_iter_reset() instead of block_iter_close()
413
- - t-reftable-block: use reftable_record_key() instead of strbuf_addstr()
414
- - t-reftable-block: use reftable_record_equal() instead of check_str()
415
- - t-reftable-block: release used block reader
416
- - t: move reftable/block_test.c to the unit testing framework
453
+* cp/unit-test-reftable-block (2024-08-19) 11 commits
454
+ . t-reftable-block: add tests for index blocks
455
+ . t-reftable-block: add tests for obj blocks
456
+ . t-reftable-block: add tests for log blocks
457
+ . t-reftable-block: remove unnecessary variable 'j'
458
+ . t-reftable-block: use xstrfmt() instead of xstrdup()
459
+ . t-reftable-block: use block_iter_reset() instead of block_iter_close()
460
+ . t-reftable-block: use reftable_record_key() instead of strbuf_addstr()
461
+ . t-reftable-block: use reftable_record_equal() instead of check_str()
462
+ . t-reftable-block: release used block reader
463
+ . t: harmonize t-reftable-block.c with coding guidelines
464
+ . t: move reftable/block_test.c to the unit testing framework
465
466
Another test for reftable library ported to the unit test framework.
467
420
- Needs Review.
421
- source: <20240814121122.4642-1-chandrapratap3519@gmail.com>
422
-
423
-
424
-* jc/tests-no-useless-tee (2024-08-08) 1 commit
425
- (merged to 'next' on 2024-08-12 at 188e777e16)
426
- + tests: drop use of 'tee' that hides exit status
427
-
428
- Test fixes.
429
-
430
- Will merge to 'master'.
431
- source: <xmqq4j7uhfvm.fsf@gitster.g>
468
+ Expecting a reroll.
469
+ cf. <CA+J6zkQa9=7C_f=NqGHEEVhnAJZQ7q9gDMhFQ_F2QDn3RDJ+cA@mail.gmail.com>
470
+ source: <20240816175414.5169-1-chandrapratap3519@gmail.com>
471
472
473
* js/libgit-rust (2024-08-09) 5 commits
@@ -440,7 +479,7 @@ Release tarballs are available at:
479
480
An rust binding to libgit.a functions has been introduced.
481
443
- Inviting further comments.
482
+ Comments?
483
source: <cover.1723242556.git.steadmon@google.com>
484
485
@@ -478,85 +517,78 @@ Release tarballs are available at:
517
518
519
* ps/leakfixes-part-4 (2024-08-14) 23 commits
481
- - builtin/diff: free symmetric diff members
482
- - diff: free state populated via options
483
- - builtin/log: fix leak when showing converted blob contents
484
- - userdiff: fix leaking memory for configured diff drivers
485
- - builtin/format-patch: fix various trivial memory leaks
486
- - diff: fix leak when parsing invalid ignore regex option
487
- - unpack-trees: clear index when not propagating it
488
- - sequencer: release todo list on error paths
489
- - merge-ort: unconditionally release attributes index
490
- - builtin/fast-export: plug leaking tag names
491
- - builtin/fast-export: fix leaking diff options
492
- - builtin/fast-import: plug trivial memory leaks
493
- - builtin/notes: fix leaking `struct notes_tree` when merging notes
494
- - builtin/rebase: fix leaking `commit.gpgsign` value
495
- - config: fix leaking comment character config
496
- - submodule-config: fix leaking name entry when traversing submodules
497
- - read-cache: fix leaking hashfile when writing index fails
498
- - bulk-checkin: fix leaking state TODO
499
- - object-name: fix leaking symlink paths in object context
500
- - object-file: fix memory leak when reading corrupted headers
501
- - git: fix leaking system paths
502
- - remote: plug memory leak when aliasing URLs
503
- - Merge branch 'ps/leakfixes-part-3' into ps/leakfixes-part-4
520
+ (merged to 'next' on 2024-08-16 at 37502271ec)
521
+ + builtin/diff: free symmetric diff members
522
+ + diff: free state populated via options
523
+ + builtin/log: fix leak when showing converted blob contents
524
+ + userdiff: fix leaking memory for configured diff drivers
525
+ + builtin/format-patch: fix various trivial memory leaks
526
+ + diff: fix leak when parsing invalid ignore regex option
527
+ + unpack-trees: clear index when not propagating it
528
+ + sequencer: release todo list on error paths
529
+ + merge-ort: unconditionally release attributes index
530
+ + builtin/fast-export: plug leaking tag names
531
+ + builtin/fast-export: fix leaking diff options
532
+ + builtin/fast-import: plug trivial memory leaks
533
+ + builtin/notes: fix leaking `struct notes_tree` when merging notes
534
+ + builtin/rebase: fix leaking `commit.gpgsign` value
535
+ + config: fix leaking comment character config
536
+ + submodule-config: fix leaking name entry when traversing submodules
537
+ + read-cache: fix leaking hashfile when writing index fails
538
+ + bulk-checkin: fix leaking state TODO
539
+ + object-name: fix leaking symlink paths in object context
540
+ + object-file: fix memory leak when reading corrupted headers
541
+ + git: fix leaking system paths
542
+ + remote: plug memory leak when aliasing URLs
543
+ + Merge branch 'ps/leakfixes-part-3' into ps/leakfixes-part-4
544
545
More leak fixes.
546
507
- Will merge to 'next'.
547
+ Will merge to 'master'.
548
source: <cover.1723614263.git.ps@pks.im>
549
550
551
* cp/unit-test-reftable-readwrite (2024-08-13) 4 commits
512
- - t-reftable-readwrite: add test for known error
513
- - t-reftable-readwrite: use 'for' in place of infinite 'while' loops
514
- - t-reftable-readwrite: use free_names() instead of a for loop
515
- - t: move reftable/readwrite_test.c to the unit testing framework
552
+ (merged to 'next' on 2024-08-16 at 8d68f73455)
553
+ + t-reftable-readwrite: add test for known error
554
+ + t-reftable-readwrite: use 'for' in place of infinite 'while' loops
555
+ + t-reftable-readwrite: use free_names() instead of a for loop
556
+ + t: move reftable/readwrite_test.c to the unit testing framework
557
517
- Will merge to 'next'.
558
+ Will merge to 'master'.
559
source: <20240813144440.4602-1-chandrapratap3519@gmail.com>
560
561
562
* ps/config-wo-the-repository (2024-08-13) 21 commits
522
- - config: hide functions using `the_repository` by default
523
- - global: prepare for hiding away repo-less config functions
524
- - config: don't depend on `the_repository` with branch conditions
525
- - config: don't have setters depend on `the_repository`
526
- - config: pass repo to functions that rename or copy sections
527
- - config: pass repo to `git_die_config()`
528
- - config: pass repo to `git_config_get_expiry_in_days()`
529
- - config: pass repo to `git_config_get_expiry()`
530
- - config: pass repo to `git_config_get_max_percent_split_change()`
531
- - config: pass repo to `git_config_get_split_index()`
532
- - config: pass repo to `git_config_get_index_threads()`
533
- - config: expose `repo_config_clear()`
534
- - config: introduce missing setters that take repo as parameter
535
- - path: hide functions using `the_repository` by default
536
- - path: stop relying on `the_repository` in `worktree_git_path()`
537
- - path: stop relying on `the_repository` when reporting garbage
538
- - hooks: remove implicit dependency on `the_repository`
539
- - editor: do not rely on `the_repository` for interactive edits
540
- - path: expose `do_git_common_path()` as `repo_common_pathv()`
541
- - path: expose `do_git_path()` as `repo_git_pathv()`
542
- - Merge branch 'ps/refs-wo-the-repository' into ps/config-wo-the-repository
563
+ (merged to 'next' on 2024-08-16 at 3d5462a90e)
564
+ + config: hide functions using `the_repository` by default
565
+ + global: prepare for hiding away repo-less config functions
566
+ + config: don't depend on `the_repository` with branch conditions
567
+ + config: don't have setters depend on `the_repository`
568
+ + config: pass repo to functions that rename or copy sections
569
+ + config: pass repo to `git_die_config()`
570
+ + config: pass repo to `git_config_get_expiry_in_days()`
571
+ + config: pass repo to `git_config_get_expiry()`
572
+ + config: pass repo to `git_config_get_max_percent_split_change()`
573
+ + config: pass repo to `git_config_get_split_index()`
574
+ + config: pass repo to `git_config_get_index_threads()`
575
+ + config: expose `repo_config_clear()`
576
+ + config: introduce missing setters that take repo as parameter
577
+ + path: hide functions using `the_repository` by default
578
+ + path: stop relying on `the_repository` in `worktree_git_path()`
579
+ + path: stop relying on `the_repository` when reporting garbage
580
+ + hooks: remove implicit dependency on `the_repository`
581
+ + editor: do not rely on `the_repository` for interactive edits
582
+ + path: expose `do_git_common_path()` as `repo_common_pathv()`
583
+ + path: expose `do_git_path()` as `repo_git_pathv()`
584
+ + Merge branch 'ps/refs-wo-the-repository' into ps/config-wo-the-repository
585
586
Use of API functions that implicitly depend on the_repository
587
object in the config subsystem has been rewritten to pass a
588
repository object through the callchain.
589
548
- Will merge to 'next'.
549
- source: <cover.1723540226.git.ps@pks.im>
550
-
551
-
552
-* ps/transport-leakfix-test-updates (2024-08-08) 1 commit
553
- (merged to 'next' on 2024-08-12 at ee80dbc4f6)
554
- + transport: mark more tests leak-free
555
-
556
- Test updates.
557
-
590
Will merge to 'master'.
559
- source: <ZrRV_HrUArsvRgn8@tanuki>
591
+ source: <cover.1723540226.git.ps@pks.im>
592
593
594
* ds/for-each-ref-is-base (2024-08-14) 4 commits
@@ -569,29 +601,10 @@ Release tarballs are available at:
601
that the history leading to a given commit "%(is-base:<commit>)" is
602
likely based on.
603
572
- Comments?
604
+ Will merge to 'next'.
605
source: <pull.1768.v3.git.1723631490.gitgitgadget@gmail.com>
606
607
576
-* sj/ref-fsck (2024-08-08) 9 commits
577
- (merged to 'next' on 2024-08-09 at 3bde10da94)
578
- + fsck: add ref name check for files backend
579
- + files-backend: add unified interface for refs scanning
580
- + builtin/refs: add verify subcommand
581
- + refs: set up ref consistency check infrastructure
582
- + fsck: add refs report function
583
- + fsck: add a unified interface for reporting fsck messages
584
- + fsck: make "fsck_error" callback generic
585
- + fsck: rename objects-related fsck error functions
586
- + fsck: rename "skiplist" to "skip_oids"
587
-
588
- "git fsck" infrastructure has been taught to also check the sanity
589
- of the ref database, in addition to the object database.
590
-
591
- Will merge to 'master'.
592
- source: <ZrSqMmD-quQ18a9F@ArchLinux.localdomain>
593
-
594
-
608
* cc/promisor-remote-capability (2024-07-31) 4 commits
609
- promisor-remote: check advertised name or URL
610
- Add 'promisor-remote' capability to protocol v2
@@ -603,39 +616,11 @@ Release tarballs are available at:
616
remotes it uses, so that the server side can omit objects that the
617
client can lazily obtain from these other promissor remotes.
618
606
- Comments?
619
+ Expecting a reroll.
620
+ cf. <ZrDYIFolRlERFdUT@tanuki>
621
source: <20240731134014.2299361-1-christian.couder@gmail.com>
622
623
610
-* tb/incremental-midx-part-1 (2024-08-06) 19 commits
611
- (merged to 'next' on 2024-08-12 at 92ec55fd49)
612
- + midx: implement support for writing incremental MIDX chains
613
- + t/t5313-pack-bounds-checks.sh: prepare for sub-directories
614
- + t: retire 'GIT_TEST_MULTI_PACK_INDEX_WRITE_BITMAP'
615
- + midx: implement verification support for incremental MIDXs
616
- + midx: support reading incremental MIDX chains
617
- + midx: teach `midx_fanout_add_midx_fanout()` about incremental MIDXs
618
- + midx: teach `midx_preferred_pack()` about incremental MIDXs
619
- + midx: teach `midx_contains_pack()` about incremental MIDXs
620
- + midx: remove unused `midx_locate_pack()`
621
- + midx: teach `fill_midx_entry()` about incremental MIDXs
622
- + midx: teach `nth_midxed_offset()` about incremental MIDXs
623
- + midx: teach `bsearch_midx()` about incremental MIDXs
624
- + midx: introduce `bsearch_one_midx()`
625
- + midx: teach `nth_bitmapped_pack()` about incremental MIDXs
626
- + midx: teach `nth_midxed_object_oid()` about incremental MIDXs
627
- + midx: teach `prepare_midx_pack()` about incremental MIDXs
628
- + midx: teach `nth_midxed_pack_int_id()` about incremental MIDXs
629
- + midx: add new fields for incremental MIDX chains
630
- + Documentation: describe incremental MIDX format
631
- (this branch is used by jk/midx-unused-fix and tb/incremental-midx-part-2.)
632
-
633
- Incremental updates of multi-pack index files.
634
-
635
- Will merge to 'master'.
636
- source: <cover.1722958595.git.me@ttaylorr.com>
637
-
638
-
624
* ja/doc-synopsis-markup (2024-08-12) 3 commits
625
- doc: apply synopsis simplification on git-clone and git-init
626
- doc: update the guidelines to reflect the current formatting rules
@@ -645,7 +630,8 @@ Release tarballs are available at:
630
been revamped. The sources, at least for the simple cases, got
631
vastly pleasant to work with.
632
648
- Comments?
633
+ Will merge to 'next'?
634
+ cf. <xmqqzfp8cm30.fsf@gitster.g>
635
source: <pull.1766.v3.git.1723389612.gitgitgadget@gmail.com>
636
637
@@ -692,20 +678,3 @@ Release tarballs are available at:
678
Expecting a reroll.
679
cf. <ZqC82sDnj7Se_aVB@tanuki>
680
source: <20240715003519.2671385-1-e@80x24.org>
695
-
696
-
697
-* rs/unit-tests-test-run (2024-07-30) 6 commits
698
- (merged to 'next' on 2024-08-12 at 9df4336877)
699
- + t-strvec: use if_test
700
- + t-reftable-basics: use if_test
701
- + t-ctype: use if_test
702
- + unit-tests: add if_test
703
- + unit-tests: show location of checks outside of tests
704
- + t0080: use here-doc test body
705
-
706
- Unit-test framework has learned a simple control structure to allow
707
- embedding test statements in-line instead of having to create a new
708
- function to contain them.
709
-
710
- Will merge to 'master'.
711
- source: <077a178e-eb30-45ff-b653-a514bfd33077@web.de>