git-clone: don't get fooled by $PWD
If you have /home/me/git symlink pointing at /pub/git/mine, trying to clone from /pub/git/his/ using relative path would not work as expected: $ cd /home/me $ cd git $ ls ../ his mine $ git clone -l -s -n ../his/stuff.git This is because "cd ../his/stuff.git" done inside git-clone to check if the repository is local is confused by $PWD, which is set to /home/me, and tries to go to /home/his/stuff.git which is different from /pub/git/his/stuff.git. We could probably say "set -P" (or "cd -P") instead, if we know the shell is POSIX, but the way the patch is coded is probably more portable. [jc: this is updated with Andy Whitcroft's improvements] Signed-off-by: Junio C Hamano <junkio@cox.net>
Junio C Hamano committed
May 9, 2007 at 17:11 UTC
c2f599e09fd0496413d1744b5b89b9b5c223555d
1 file changed
+8
-1
git-clone.sh
+8
-1
@@ -18,7 +18,14 @@ usage() {
18
}
19
20
get_repo_base() {
21
- (cd "$1" && (cd .git ; pwd)) 2> /dev/null
21
+ (
22
+ cd "`/bin/pwd`" &&
23
+ cd "$1" &&
24
+ {
25
+ cd .git 2>/dev/null
26
+ pwd
27
+ }
28
+ )
29
}
30
31
if [ -n "$GIT_SSL_NO_VERIFY" ]; then