t6301: new tests of for-each-ref error handling

Add tests that for-each-ref correctly reports broken loose reference files and references that point at missing objects. In fact, two of these tests fail, because (1) NULL_SHA1 is not recognized as an invalid reference value, and (2) for-each-ref doesn't respect REF_ISBROKEN. Fixes to come. Note that when for-each-ref is run with a --format option that doesn't require the object to be looked up, then we should still notice if a loose reference file is corrupt or contains NULL_SHA1, but we don't notice if it points at a missing object because we don't do an object lookup. This is OK. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Michael Haggerty committed Jun 2, 2015 at 17:57 UTC c3e23dc117beae7e89e81aed28b0e082a14d672e
1 file changed +56
t/t6301-for-each-ref-errors.sh new
+56
@@ -0,0 +1,56 @@
1 +#!/bin/sh
2 +
3 +test_description='for-each-ref errors for broken refs'
4 +
5 +. ./test-lib.sh
6 +
7 +ZEROS=$_z40
8 +MISSING=abababababababababababababababababababab
9 +
10 +test_expect_success setup '
11 + git commit --allow-empty -m "Initial" &&
12 + git tag testtag &&
13 + git for-each-ref >full-list &&
14 + git for-each-ref --format="%(objectname) %(refname)" >brief-list
15 +'
16 +
17 +test_expect_failure 'Broken refs are reported correctly' '
18 + r=refs/heads/bogus &&
19 + : >.git/$r &&
20 + test_when_finished "rm -f .git/$r" &&
21 + echo "warning: ignoring broken ref $r" >broken-err &&
22 + git for-each-ref >out 2>err &&
23 + test_cmp full-list out &&
24 + test_cmp broken-err err
25 +'
26 +
27 +test_expect_failure 'NULL_SHA1 refs are reported correctly' '
28 + r=refs/heads/zeros &&
29 + echo $ZEROS >.git/$r &&
30 + test_when_finished "rm -f .git/$r" &&
31 + echo "warning: ignoring broken ref $r" >zeros-err &&
32 + git for-each-ref >out 2>err &&
33 + test_cmp full-list out &&
34 + test_cmp zeros-err err &&
35 + git for-each-ref --format="%(objectname) %(refname)" >brief-out 2>brief-err &&
36 + test_cmp brief-list brief-out &&
37 + test_cmp zeros-err brief-err
38 +'
39 +
40 +test_expect_success 'Missing objects are reported correctly' '
41 + r=refs/heads/missing &&
42 + echo $MISSING >.git/$r &&
43 + test_when_finished "rm -f .git/$r" &&
44 + echo "fatal: missing object $MISSING for $r" >missing-err &&
45 + test_must_fail git for-each-ref 2>err &&
46 + test_cmp missing-err err &&
47 + (
48 + cat brief-list &&
49 + echo "$MISSING $r"
50 + ) | sort -k 2 >missing-brief-expected &&
51 + git for-each-ref --format="%(objectname) %(refname)" >brief-out 2>brief-err &&
52 + test_cmp missing-brief-expected brief-out &&
53 + test_must_be_empty brief-err
54 +'
55 +
56 +test_done