@matheusbsbs / matheus-bagliano / commits / c41e20b30b
Fork 0

send-pack: remove remote reference limit

When build a pack for a push we query the remote copy for existant heads. These are used to prune unnecessary objects from the pack. As we receive the remote references in get_remote_heads() we validate the reference names via check_ref() which includes a length check; rejecting those >45 characters in size. This is a miss converted change, it was originally designed to reject messages which were less than 45 characters in length (a 40 character sha1 and refs/) to prevent comparing unitialised memory. check_ref() now gets the raw length so check for at least 5 characters. Signed-off-by: Andy Whitcroft <apw@shadowen.org> Signed-off-by: Junio C Hamano <junkio@cox.net>

Andy Whitcroft committed Sep 5, 2006 at 20:00 UTC c41e20b30b2bd4b8167917336676cde6f6aadd06
1 file changed +1 -1
connect.c
+1 -1
@@ -17,7 +17,7 @@ static int check_ref(const char *name, int len, unsigned int flags)
17 if (!flags)
18 return 1;
19
20 - if (len > 45 || memcmp(name, "refs/", 5))
20 + if (len < 5 || memcmp(name, "refs/", 5))
21 return 0;
22
23 /* Skip the "refs/" part */