@matheusbsbs / matheus-bagliano / commits / c43b7e6089

perf aggregate: remove GIT_TEST_INSTALLED from --codespeed

Remove the setting of the "environment" from the --codespeed output. I don't think this is useful, and it helps with a later refactoring where we GIT_TEST_INSTALLED stop munging/reading GIT_TEST_INSTALLED in the perf tests in so many places. This was added in 05eb1c37ed ("perf/aggregate: implement codespeed JSON output", 2018-01-05), but since the "run" scripts uses "GIT_TEST_INSTALLED" internally this was only ever useful for one-off runs of a single revision as all the "environment" values would be ones for whatever directory the "run" script ran last. Let's instead fall back on the "uname -r" case, which is the sort of thing the environment should be set to, not something that duplicates other parts of the codpseed output. For setting the "environment" to something custom the perf.repoName variable can be used. See 19cf57a92e ("perf/run: read GIT_PERF_REPO_NAME from perf.repoName", 2018-01-05). Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Ævar Arnfjörð Bjarmason committed May 7, 2019 at 12:54 UTC c43b7e6089629b05d5af6995e99d5149ae5c3621

1 file changed -3

t/perf/aggregate.perl

-3

@@ -312,9 +312,6 @@ sub print_codespeed_results {

312 $environment = $reponame;

313 } elsif (exists $ENV{GIT_PERF_REPO_NAME} and $ENV{GIT_PERF_REPO_NAME} ne "") {

314 $environment = $ENV{GIT_PERF_REPO_NAME};

315 - } elsif (exists $ENV{GIT_TEST_INSTALLED} and $ENV{GIT_TEST_INSTALLED} ne "") {

316 - $environment = $ENV{GIT_TEST_INSTALLED};

317 - $environment =~ s|/bin-wrappers$||;

315 } else {

316 $environment = `uname -r`;

317 chomp $environment;