t5504: drop sigpipe=ok from push tests
These were added by 8bf4bec (add "ok=sigpipe" to test_must_fail and use it to fix flaky tests, 2015-11-27) because we would racily die via SIGPIPE when the pack was rejected by the other side. But since we have recently de-flaked send-pack, we should be able to tighten up these tests (including re-adding the expected output checks). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Apr 19, 2016 at 18:51 UTC
c4b27511ab0e3ec464e3fd3d4711251a17b1f733
1 file changed
+4
-6
t/t5504-fetch-receive-strict.sh
+4
-6
@@ -100,11 +100,8 @@ test_expect_success 'push with receive.fsckobjects' '
100
git config receive.fsckobjects true &&
101
git config transfer.fsckobjects false
102
) &&
103
- test_must_fail ok=sigpipe git push --porcelain dst master:refs/heads/test >act &&
104
- {
105
- test_cmp exp act ||
106
- ! test -s act
107
- }
103
+ test_must_fail git push --porcelain dst master:refs/heads/test >act &&
104
+ test_cmp exp act
105
'
106
107
test_expect_success 'push with transfer.fsckobjects' '
@@ -114,7 +111,8 @@ test_expect_success 'push with transfer.fsckobjects' '
111
cd dst &&
112
git config transfer.fsckobjects true
113
) &&
117
- test_must_fail ok=sigpipe git push --porcelain dst master:refs/heads/test >act
114
+ test_must_fail git push --porcelain dst master:refs/heads/test >act &&
115
+ test_cmp exp act
116
'
117
118
cat >bogus-commit <<\EOF