t9350-fast-export.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Jan 12, 2016 at 11:49 UTC
c7b793a17d92350632c51a24e06b6a3dc4a93c2b
1 file changed
+3
-3
t/t9350-fast-export.sh
+3
-3
@@ -163,7 +163,7 @@ test_expect_success 'setup submodule' '
163
git add file &&
164
git commit -m sub_initial
165
) &&
166
- git submodule add "`pwd`/sub" sub &&
166
+ git submodule add "$(pwd)/sub" sub &&
167
git commit -m initial &&
168
test_tick &&
169
(
@@ -377,7 +377,7 @@ test_expect_success 'full-tree re-shows unmodified files' '
377
378
test_expect_success 'set-up a few more tags for tag export tests' '
379
git checkout -f master &&
380
- HEAD_TREE=`git show -s --pretty=raw HEAD | grep tree | sed "s/tree //"` &&
380
+ HEAD_TREE=$(git show -s --pretty=raw HEAD | grep tree | sed "s/tree //") &&
381
git tag tree_tag -m "tagging a tree" $HEAD_TREE &&
382
git tag -a tree_tag-obj -m "tagging a tree" $HEAD_TREE &&
383
git tag tag-obj_tag -m "tagging a tag" tree_tag-obj &&
@@ -422,7 +422,7 @@ test_expect_success 'directory becomes symlink' '
422
test_expect_success 'fast-export quotes pathnames' '
423
git init crazy-paths &&
424
(cd crazy-paths &&
425
- blob=`echo foo | git hash-object -w --stdin` &&
425
+ blob=$(echo foo | git hash-object -w --stdin) &&
426
git update-index --add \
427
--cacheinfo 100644 $blob "$(printf "path with\\nnewline")" \
428
--cacheinfo 100644 $blob "path with \"quote\"" \