fetch-pack, send-pack: clean up shallow oid array
When we call get_remote_heads() for protocol v0, that may populate the "shallow" oid_array, which must be cleaned up to avoid a leak at the program exit. The same problem exists for both fetch-pack and send-pack, but not for the usual transport.c code paths, since we already do this cleanup in disconnect_git(). Fixing this lets us mark t5542 as leak-free for the send-pack side, but fetch-pack will need some more fixes before we can do the same for t5539. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Sep 24, 2024 at 17:52 UTC
c8009635785e656cfed3b814beb4eab9fd16eac3
3 files changed
+3
builtin/fetch-pack.c
+1
@@ -294,5 +294,6 @@ int cmd_fetch_pack(int argc,
294
free_refs(fetched_refs);
295
free_refs(remote_refs);
296
list_objects_filter_release(&args.filter_options);
297
+ oid_array_clear(&shallow);
298
return ret;
299
}
builtin/send-pack.c
+1
@@ -343,5 +343,6 @@ int cmd_send_pack(int argc,
343
free_refs(remote_refs);
344
free_refs(local_refs);
345
refspec_clear(&rs);
346
+ oid_array_clear(&shallow);
347
return ret;
348
}
t/t5542-push-http-shallow.sh
+1
@@ -5,6 +5,7 @@ test_description='push from/to a shallow clone over http'
5
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
6
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
7
8
+TEST_PASSES_SANITIZE_LEAK=true
9
. ./test-lib.sh
10
. "$TEST_DIRECTORY"/lib-httpd.sh
11
start_httpd