@matheusbsbs / matheus-bagliano / commits / c8744d6a8b
Fork 0

unquote_c_style: fix off-by-one.

The optional endp parameter to unquote_c_style() was supposed to point at a location past the closing double quote, but it was going one beyond it. git-fast-import used this function heavily and the bug caused it to misparse the input stream, especially when parsing a rename command: R "filename that needs quoting" rename-target-name Because the function erroneously ate the whitespace after the closing dq, this triggered "Missing space after source" error when it shouldn't. Thanks to Adeodato Simò for having caught this. Signed-off-by: Pierre Habouzit <madcoder@debian.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Pierre Habouzit committed Mar 6, 2008 at 22:28 UTC c8744d6a8b27115503565041566d97c21e722584
1 file changed +1 -1
quote.c
+1 -1
@@ -288,7 +288,7 @@ int unquote_c_style(struct strbuf *sb, const char *quoted, const char **endp)
288 switch (*quoted++) {
289 case '"':
290 if (endp)
291 - *endp = quoted + 1;
291 + *endp = quoted;
292 return 0;
293 case '\\':
294 break;