fsmonitor: don't bother pretty-printing JSON from watchman

This provides modest performance savings. Benchmarking with the following program, with and without `--no-pretty`, we find savings of 23% (0.316s -> 0.242s) in the git repository, and savings of 8% (5.24s -> 4.86s) on a large repository with 580k files in the working copy. #!/usr/bin/perl use strict; use warnings; use IPC::Open2; use JSON::XS; my $pid = open2(\*CHLD_OUT, \*CHLD_IN, "watchman -j @ARGV") or die "open2() failed: $!\n" . "Falling back to scanning...\n"; my $query = qq|["query", "$ENV{PWD}", {}]|; print CHLD_IN $query; close CHLD_IN; my $response = do {local $/; <CHLD_OUT>}; JSON::XS->new->utf8->decode($response); Signed-off-by: Alex Vandiver <alexmv@dropbox.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Alex Vandiver committed Oct 27, 2017 at 16:26 UTC c87fbcf7614a064877cd0323f0ed31840fed9c0c
1 file changed +1 -1
templates/hooks--fsmonitor-watchman.sample
+1 -1
@@ -49,7 +49,7 @@ launch_watchman();
49
50 sub launch_watchman {
51
52 - my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j')
52 + my $pid = open2(\*CHLD_OUT, \*CHLD_IN, 'watchman -j --no-pretty')
53 or die "open2() failed: $!\n" .
54 "Falling back to scanning...\n";
55