xprepare: simplify error handling
If either of the two allocations fail we want to take the same action so use a single if statement. This saves a few lines and makes it easier for the next commit to add a couple more allocations. Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Phillip Wood committed
May 4, 2026 at 15:06 UTC
c8eb18f58607057a812654bdfca3e6b47bd0ffe4
1 file changed
+2
-5
xdiff/xprepare.c
+2
-5
@@ -282,11 +282,8 @@ static int xdl_cleanup_records(xdlclassifier_t *cf, xdfile_t *xdf1, xdfile_t *xd
282
* Create temporary arrays that will help us decide if
283
* changed[i] should remain false, or become true.
284
*/
285
- if (!XDL_CALLOC_ARRAY(action1, len1)) {
286
- ret = -1;
287
- goto cleanup;
288
- }
289
- if (!XDL_CALLOC_ARRAY(action2, len2)) {
285
+ if (!XDL_CALLOC_ARRAY(action1, len1) ||
286
+ !XDL_CALLOC_ARRAY(action2, len2)) {
287
ret = -1;
288
goto cleanup;
289
}