t1400: use test_must_be_empty
Use test_must_be_empty instead of reading the file and comparing its contents to an empty string. That's more efficient, as the function only needs built-in meta-data only check in the usual case, and provides nicer debug output otherwise. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
René Scharfe committed
Nov 26, 2019 at 20:41 UTC
c93a5aaec859f93ff24277269e2fdef00c9c45e6
1 file changed
+4
-4
t/t1400-update-ref.sh
+4
-4
@@ -378,13 +378,13 @@ test_expect_success 'Query "master@{May 26 2005 23:32:00}" (exactly history star
378
test_when_finished "rm -f o e" &&
379
git rev-parse --verify "master@{May 26 2005 23:32:00}" >o 2>e &&
380
test $C = $(cat o) &&
381
- test "" = "$(cat e)"
381
+ test_must_be_empty e
382
'
383
test_expect_success 'Query "master@{May 26 2005 23:32:30}" (first non-creation change)' '
384
test_when_finished "rm -f o e" &&
385
git rev-parse --verify "master@{May 26 2005 23:32:30}" >o 2>e &&
386
test $A = $(cat o) &&
387
- test "" = "$(cat e)"
387
+ test_must_be_empty e
388
'
389
test_expect_success 'Query "master@{2005-05-26 23:33:01}" (middle of history with gap)' '
390
test_when_finished "rm -f o e" &&
@@ -396,13 +396,13 @@ test_expect_success 'Query "master@{2005-05-26 23:38:00}" (middle of history)' '
396
test_when_finished "rm -f o e" &&
397
git rev-parse --verify "master@{2005-05-26 23:38:00}" >o 2>e &&
398
test $Z = $(cat o) &&
399
- test "" = "$(cat e)"
399
+ test_must_be_empty e
400
'
401
test_expect_success 'Query "master@{2005-05-26 23:43:00}" (exact end of history)' '
402
test_when_finished "rm -f o e" &&
403
git rev-parse --verify "master@{2005-05-26 23:43:00}" >o 2>e &&
404
test $E = $(cat o) &&
405
- test "" = "$(cat e)"
405
+ test_must_be_empty e
406
'
407
test_expect_success 'Query "master@{2005-05-28}" (past end of history)' '
408
test_when_finished "rm -f o e" &&