pickaxe tests: add test for diffgrep_consume() internals
In diffgrep_consume() we generate a diff, and then advance past the "+" or "-" at the start of the line for matching. This has been done ever since the code was added in f506b8e8b5f (git log/diff: add -G<regexp> that greps in the patch text, 2010-08-23). If we match "line" instead of "line + 1" no tests fail, i.e. we've got zero coverage for whether any of our searches match the beginning of the line or not. Let's add a test for this. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Apr 12, 2021 at 19:15 UTC
c9609398580518dffaadaace17188c901a4a4522
1 file changed
+15
t/t4209-log-pickaxe.sh
+15
@@ -106,6 +106,21 @@ test_expect_success 'log -S --no-textconv (missing textconv tool)' '
106
rm .gitattributes
107
'
108
109
+test_expect_success 'setup log -[GS] plain' '
110
+ test_create_repo GS-plain &&
111
+ test_commit -C GS-plain --append A data.txt "a" &&
112
+ test_commit -C GS-plain --append B data.txt "a a" &&
113
+ test_commit -C GS-plain C data.txt "" &&
114
+ git -C GS-plain log >full-log
115
+'
116
+
117
+test_expect_success 'log -G trims diff new/old [-+]' '
118
+ git -C GS-plain log -G"[+-]a" >log &&
119
+ test_must_be_empty log &&
120
+ git -C GS-plain log -G"^a" >log &&
121
+ test_cmp log full-log
122
+'
123
+
124
test_expect_success 'setup log -[GS] binary & --text' '
125
test_create_repo GS-bin-txt &&
126
test_commit -C GS-bin-txt --printf A data.bin "a\na\0a\n" &&