t9360-mw-to-git-clone.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Apr 16, 2014 at 10:29 UTC
c9b92706af6441ba91fec314b6aac7f105e61b22
1 file changed
+7
-7
contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
+7
-7
@@ -191,10 +191,10 @@ test_expect_success 'Git clone works with the shallow option' '
191
test_path_is_file mw_dir_11/Main_Page.mw &&
192
(
193
cd mw_dir_11 &&
194
- test `git log --oneline Nyan.mw | wc -l` -eq 1 &&
195
- test `git log --oneline Foo.mw | wc -l` -eq 1 &&
196
- test `git log --oneline Bar.mw | wc -l` -eq 1 &&
197
- test `git log --oneline Main_Page.mw | wc -l ` -eq 1
194
+ test $(git log --oneline Nyan.mw | wc -l) -eq 1 &&
195
+ test $(git log --oneline Foo.mw | wc -l) -eq 1 &&
196
+ test $(git log --oneline Bar.mw | wc -l) -eq 1 &&
197
+ test $(git log --oneline Main_Page.mw | wc -l ) -eq 1
198
) &&
199
wiki_check_content mw_dir_11/Nyan.mw Nyan &&
200
wiki_check_content mw_dir_11/Foo.mw Foo &&
@@ -218,9 +218,9 @@ test_expect_success 'Git clone works with the shallow option with a delete page'
218
test_path_is_file mw_dir_12/Main_Page.mw &&
219
(
220
cd mw_dir_12 &&
221
- test `git log --oneline Nyan.mw | wc -l` -eq 1 &&
222
- test `git log --oneline Bar.mw | wc -l` -eq 1 &&
223
- test `git log --oneline Main_Page.mw | wc -l ` -eq 1
221
+ test $(git log --oneline Nyan.mw | wc -l) -eq 1 &&
222
+ test $(git log --oneline Bar.mw | wc -l) -eq 1 &&
223
+ test $(git log --oneline Main_Page.mw | wc -l ) -eq 1
224
) &&
225
wiki_check_content mw_dir_12/Nyan.mw Nyan &&
226
wiki_check_content mw_dir_12/Bar.mw Bar &&