trace2: trim_trailing_newline followed by trim is a no-op
strbuf_trim_trailing_newline() removes a LF or a CRLF from the tail of a string. If the code plans to call strbuf_trim() immediately after doing so, the code is better off skipping the EOL trimming in the first place. After all, LF/CRLF at the end is a mere special case of whitespaces at the end of the string, which will be removed by strbuf_rtrim() anyway. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Jul 31, 2025 at 15:54 UTC
cb8e82a6414653d5dbda81eedb8ca0cd9ce34c68
1 file changed
-2
trace2/tr2_cfg.c
-2
@@ -39,7 +39,6 @@ static int tr2_cfg_load_patterns(void)
39
40
if (buf->len && buf->buf[buf->len - 1] == ',')
41
strbuf_setlen(buf, buf->len - 1);
42
- strbuf_trim_trailing_newline(*s);
42
strbuf_trim(*s);
43
}
44
@@ -78,7 +77,6 @@ static int tr2_load_env_vars(void)
77
78
if (buf->len && buf->buf[buf->len - 1] == ',')
79
strbuf_setlen(buf, buf->len - 1);
81
- strbuf_trim_trailing_newline(*s);
80
strbuf_trim(*s);
81
}
82