gitweb: esc_html_hl_regions(): Don't create empty <span> elements
If $end is equal to or less than $begin, esc_html_hl_regions() generates an empty <span> element. It normally shouldn't be visible in the web browser, but it doesn't look good when looking at page source. It also minimally increases generated page size for no special reason. Signed-off-by: Michał Kiedrowicz <michal.kiedrowicz@gmail.com> Acked-by: Jakub Narębski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Michał Kiedrowicz committed
Apr 11, 2012 at 23:18 UTC
cbbea3dfc1a1cfe382e58488c389471b4ab21876
1 file changed
+3
gitweb/gitweb.perl
+3
@@ -1740,6 +1740,9 @@ sub esc_html_hl_regions {
1740
for my $s (@sel) {
1741
my ($begin, $end) = @$s;
1742
1743
+ # Don't create empty <span> elements.
1744
+ next if $end <= $begin;
1745
+
1746
my $escaped = esc_html(substr($str, $begin, $end - $begin));
1747
1748
$out .= esc_html(substr($str, $pos, $begin - $pos))