t/t1100-commit-tree-options.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Dec 22, 2015 at 16:05 UTC
cbda02fcb7254029f0f5cb4a0ce623700da01b00
1 file changed
+2
-2
t/t1100-commit-tree-options.sh
+2
-2
@@ -35,11 +35,11 @@ test_expect_success \
35
GIT_COMMITTER_NAME="Committer Name" \
36
GIT_COMMITTER_EMAIL="committer@email" \
37
GIT_COMMITTER_DATE="2005-05-26 23:30" \
38
- TZ=GMT git commit-tree `cat treeid` >commitid 2>/dev/null'
38
+ TZ=GMT git commit-tree $(cat treeid) >commitid 2>/dev/null'
39
40
test_expect_success \
41
'read commit' \
42
- 'git cat-file commit `cat commitid` >commit'
42
+ 'git cat-file commit $(cat commitid) >commit'
43
44
test_expect_success \
45
'compare commit' \