remote-curl: tighten "version 2" check for smart-http
In a v2 smart-http conversation, the server should reply to our initial request with a pkt-line saying "version 2". We check that with starts_with(), but really that should be the only thing in that packet. A response of "version 20" should not match. Let's tighten this check to use strcmp(). Note that we don't need to worry about a trailing newline here, because the ptk-line code will have chomped it for us already. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Feb 6, 2019 at 14:18 UTC
cbdb8d14392690f2e540b9efdb245871a043eb06
1 file changed
+1
-1
remote-curl.c
+1
-1
@@ -374,7 +374,7 @@ static void check_smart_http(struct discovery *d, const char *service,
374
d->len = reader.src_len;
375
d->proto_git = 1;
376
377
- } else if (starts_with(reader.line, "version 2")) {
377
+ } else if (!strcmp(reader.line, "version 2")) {
378
/*
379
* v2 smart http; do not consume version packet, which will
380
* be handled elsewhere.