vcs-svn: allow character-oriented input
buffer_read_char can be used in place of buffer_read_string(1) to avoid consuming valuable static buffer space. The delta applier will use this to read variable-length integers one byte at a time. Underneath, it is fgetc, wrapped so the line_buffer library can maintain its role as gatekeeper of input. Later it might be worth checking if fgetc_unlocked is faster --- most line_buffer functions are not thread-safe anyway. Helpd-by: David Barr <david.barr@cordelta.com> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Jonathan Nieder committed
Jan 2, 2011 at 21:06 UTC
cc193f1f0b45e4e65f246f1d5e6e8134844aa35b
2 files changed
+6
vcs-svn/line_buffer.c
+5
@@ -27,6 +27,11 @@ int buffer_deinit(struct line_buffer *buf)
27
return err;
28
}
29
30
+int buffer_read_char(struct line_buffer *buf)
31
+{
32
+ return fgetc(buf->infile);
33
+}
34
+
35
/* Read a line without trailing newline. */
36
char *buffer_read_line(struct line_buffer *buf)
37
{
vcs-svn/line_buffer.h
+1
@@ -16,6 +16,7 @@ int buffer_init(struct line_buffer *buf, const char *filename);
16
int buffer_deinit(struct line_buffer *buf);
17
char *buffer_read_line(struct line_buffer *buf);
18
char *buffer_read_string(struct line_buffer *buf, uint32_t len);
19
+int buffer_read_char(struct line_buffer *buf);
20
void buffer_read_binary(struct line_buffer *buf, struct strbuf *sb, uint32_t len);
21
void buffer_copy_bytes(struct line_buffer *buf, uint32_t len);
22
void buffer_skip_bytes(struct line_buffer *buf, uint32_t len);