contrib/examples/git-fetch.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Dec 22, 2015 at 15:10 UTC
cc301d7e5193801208588cbd54cf1af91b6f7a00
1 file changed
+2
-2
contrib/examples/git-fetch.sh
+2
-2
@@ -146,13 +146,13 @@ esac
146
reflist=$(get_remote_refs_for_fetch "$@")
147
if test "$tags"
148
then
149
- taglist=`IFS=' ' &&
149
+ taglist=$(IFS=' ' &&
150
echo "$ls_remote_result" |
151
git show-ref --exclude-existing=refs/tags/ |
152
while read sha1 name
153
do
154
echo ".${name}:${name}"
155
- done` || exit
155
+ done) || exit
156
if test "$#" -gt 1
157
then
158
# remote URL plus explicit refspecs; we need to merge them.