test-ref-store: avoid passing NULL to printf

It's possible for resolve_ref_unsafe() to return NULL (e.g., if we are reading and the ref does not exist), in which case we'll pass NULL to printf. On glibc systems this produces "(null)", but on others it may segfault. The tests don't expect any such case, but if we ever did trigger this, we would prefer to cleanly fail the test with unexpected input rather than segfault. Let's manually replace NULL with "(null)". The exact value doesn't matter, as it won't match any possible ref the caller could expect (and anyway, the exit code of the program will tell whether "ref" is valid or not). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Oct 19, 2017 at 13:46 UTC cc61cf465f7777d0aebd1a35ca72650fef8f253f
1 file changed +1 -1
t/helper/test-ref-store.c
+1 -1
@@ -135,7 +135,7 @@ static int cmd_resolve_ref(struct ref_store *refs, const char **argv)
135
136 ref = refs_resolve_ref_unsafe(refs, refname, resolve_flags,
137 sha1, &flags);
138 - printf("%s %s 0x%x\n", sha1_to_hex(sha1), ref, flags);
138 + printf("%s %s 0x%x\n", sha1_to_hex(sha1), ref ? ref : "(null)", flags);
139 return ref ? 0 : 1;
140 }
141