@matheusbsbs / matheus-bagliano / commits / ccdbdc79a3

send-email: auth plain/login fix

git send-email was not authenticating properly when communicating over TLS with a server supporting only AUTH PLAIN and AUTH LOGIN. This is e.g. the standard server setup under debian with exim4 and probably everywhere where system accounts are used. The problem (only?) exists when libauthen-sasl-cyrus-perl (Authen::SASL::Cyrus) is installed. Importing Authen::SASL::Perl makes Authen::SASL use the perl implementation which works better. The solution is based on this forum thread: http://www.perlmonks.org/?node_id=904354. This patch is tested by sending it. Without this fix, the interaction with the server failed like this: $ git send-email --smtp-encryption=tls --smtp-server=... --smtp-debug=1 change1.patch ... Net::SMTP::SSL=GLOB(0x238f668)<<< 250-AUTH LOGIN PLAIN Password: Net::SMTP::SSL=GLOB(0x238f668)>>> AUTH Net::SMTP::SSL=GLOB(0x238f668)<<< 501 5.5.2 AUTH mechanism must be specified 5.5.2 AUTH mechanism must be specified Signed-off-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Zbigniew Jędrzejewski-Szmek committed Sep 29, 2011 at 19:02 UTC ccdbdc79a30413d93d32cc7e5293185228f05459
1 file changed +6
git-send-email.perl
+6
@@ -1095,6 +1095,12 @@ X-Mailer: git-send-email $gitversion
1095 }
1096
1097 if (defined $smtp_authuser) {
1098 + # Workaround AUTH PLAIN/LOGIN interaction defect
1099 + # with Authen::SASL::Cyrus
1100 + eval {
1101 + require Authen::SASL;
1102 + Authen::SASL->import(qw(Perl));
1103 + };
1104
1105 if (!defined $smtp_authpass) {
1106