Windows: Fix ntohl() related warnings about printf formatting
On Windows, ntohl() returns unsigned long. On Unix it returns uint32_t. This makes choosing a suitable printf format string hard. This commit introduces a mingw specific helper function git_ntohl() that casts to unsigned int before returning. This makes gcc's printf format check happy. It should be safe because we expect ntohl to use 32-bit numbers. Signed-off-by: Steffen Prohaska <prohaska@zib.de> Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
Steffen Prohaska committed
Nov 17, 2007 at 19:16 UTC
cd800eecc27ef57cb934f349f116cd7022ec71ed
1 file changed
+4
compat/mingw.h
+4
@@ -186,6 +186,10 @@ pid_t mingw_spawnvpe(const char *cmd, const char **argv, char **env);
186
void mingw_execvp(const char *cmd, char *const *argv);
187
#define execvp mingw_execvp
188
189
+static inline unsigned int git_ntohl(unsigned int x)
190
+{ return (unsigned int)ntohl(x); }
191
+#define ntohl git_ntohl
192
+
193
sig_handler_t mingw_signal(int sig, sig_handler_t handler);
194
#define signal mingw_signal
195