t4204-patch-id.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Apr 30, 2014 at 09:23 UTC
ce21ccfae0729fd73b54f3ae4935fc7769343561
1 file changed
+2
-2
t/t4204-patch-id.sh
+2
-2
@@ -45,8 +45,8 @@ test_expect_success 'patch-id supports git-format-patch output' '
45
git checkout same &&
46
git format-patch -1 --stdout | calc_patch_id same &&
47
test_cmp patch-id_master patch-id_same &&
48
- set `git format-patch -1 --stdout | git patch-id` &&
49
- test "$2" = `git rev-parse HEAD`
48
+ set $(git format-patch -1 --stdout | git patch-id) &&
49
+ test "$2" = $(git rev-parse HEAD)
50
'
51
52
test_expect_success 'whitespace is irrelevant in footer' '