git-gui: Fix accidental staged state toggle when clicking top pixel row
If a text widget is asked the index at x,y with y == 0 or y == 1 it will always return 1.0 as the nearest index, regardless of the x position. This means that clicking the top 2 pixels of the Unstaged/Staged Changes lists caused the state of the file there to be toggled. This patch checks that the pixel clicked is greater than 1, so there is less chance of accidentally staging or unstaging changes. Signed-off-by: Richard Quirk <richard.quirk@gmail.com> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Richard Quirk committed
Jun 20, 2008 at 16:58 UTC
cead78edef6a2f1339f699cd7d656b6834707b94
1 file changed
+1
-1
git-gui.sh
+1
-1
@@ -1797,7 +1797,7 @@ proc toggle_or_diff {w x y} {
1797
$ui_index tag remove in_sel 0.0 end
1798
$ui_workdir tag remove in_sel 0.0 end
1799
1800
- if {$col == 0} {
1800
+ if {$col == 0 && $y > 1} {
1801
set i [expr {$lno-1}]
1802
set ll [expr {[llength $file_lists($w)]-1}]
1803