@matheusbsbs / matheus-bagliano / commits / ced78b3907
Fork 0

clone: the given repository dir should be relative to $PWD

the repository argument for git-clone should be relative to $PWD instead of the given target directory. The old behavior gave us surprising success and you need a few minute to know why it worked. GIT_DIR is already exported so no need to cd into $D. And this makes $PWD for git-fetch-pack, which is the actual command to take the given repository dir, the same as git-clone. Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com> Signed-off-by: Junio C Hamano <junkio@cox.net>

Yasushi SHOJI committed Oct 14, 2006 at 21:02 UTC ced78b3907dd60d8289ad5385ffcfd3339149957
2 files changed +7 -1
git-clone.sh
+1 -1
@@ -312,7 +312,7 @@ yes,yes)
312 fi
313 ;;
314 *)
315 - cd "$D" && case "$upload_pack" in
315 + case "$upload_pack" in
316 '') git-fetch-pack --all -k $quiet "$repo" ;;
317 *) git-fetch-pack --all -k $quiet "$upload_pack" "$repo" ;;
318 esac >"$GIT_DIR/CLONE_HEAD" || {
t/t5600-clone-fail-cleanup.sh
+6
@@ -25,6 +25,12 @@ test_create_repo foo
25 # clone doesn't like it if there is no HEAD. Is that a bug?
26 (cd foo && touch file && git add file && git commit -m 'add file' >/dev/null 2>&1)
27
28 +# source repository given to git-clone should be relative to the
29 +# current path not to the target dir
30 +test_expect_failure \
31 + 'clone of non-existent (relative to $PWD) source should fail' \
32 + 'git-clone ../foo baz'
33 +
34 test_expect_success \
35 'clone should work now that source exists' \
36 'git-clone foo bar'