format-patch: free rev.message_id when exiting
We may allocate a message-id string via gen_message_id(), but we never free it, causing a small leak. This can be demonstrated by running t9001 with a leak-checking build. The offending test is the one touched by 3ece9bf0f9 (send-email: clear the $message_id after validation, 2023-05-17), but the leak is much older than that. The test was simply unlucky enough to trigger the leaking code path for the first time. We can fix this by freeing the string at the end of the function. We can also re-mark the test script as leak-free, effectively reverting 20bd08aefb (t9001: mark the script as no longer leak checker clean, 2023-05-17). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
May 18, 2023 at 20:03 UTC
cfa120947e6337e7be2658f71a0132e337ee090a
2 files changed
+2
-1
builtin/log.c
+1
@@ -2415,6 +2415,7 @@ done:
2415
strbuf_release(&rdiff_title);
2416
strbuf_release(&sprefix);
2417
free(to_free);
2418
+ free(rev.message_id);
2419
if (rev.ref_message_ids)
2420
string_list_clear(rev.ref_message_ids, 0);
2421
free(rev.ref_message_ids);
t/t9001-send-email.sh
+1
-1
@@ -4,7 +4,7 @@ test_description='git send-email'
4
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
5
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
6
7
-# no longer TEST_PASSES_SANITIZE_LEAK=true - format-patch --thread leaks
7
+TEST_PASSES_SANITIZE_LEAK=true
8
. ./test-lib.sh
9
10
# May be altered later in the test