http: mark unused parameters in curl callbacks
These functions are all used as callbacks for curl, so they have to conform to a particular interface. But they don't need all of their parameters: - fwrite_null() throws away the input, so it doesn't look at most parameters - fwrite_wwwauth() in theory could take the auth struct in its void pointer, but instead we just access it as the global http_auth (matching the rest of the code in this file) - curl_trace() always writes via the trace mechanism, so it doesn't need its void pointer to know where to send things. Likewise, it ignores the CURL parameter, since nothing we trace requires querying the handle. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jul 3, 2023 at 02:44 UTC
d0144007b185f5da87f197ceacc4aa5548d4214e
1 file changed
+6
-3
http.c
+6
-3
@@ -196,7 +196,7 @@ static inline int is_hdr_continuation(const char *ptr, const size_t size)
196
return size && (*ptr == ' ' || *ptr == '\t');
197
}
198
199
-static size_t fwrite_wwwauth(char *ptr, size_t eltsize, size_t nmemb, void *p)
199
+static size_t fwrite_wwwauth(char *ptr, size_t eltsize, size_t nmemb, void *p UNUSED)
200
{
201
size_t size = eltsize * nmemb;
202
struct strvec *values = &http_auth.wwwauth_headers;
@@ -295,7 +295,8 @@ exit:
295
return size;
296
}
297
298
-size_t fwrite_null(char *ptr, size_t eltsize, size_t nmemb, void *strbuf)
298
+size_t fwrite_null(char *ptr UNUSED, size_t eltsize UNUSED, size_t nmemb,
299
+ void *data UNUSED)
300
{
301
return nmemb;
302
}
@@ -821,7 +822,9 @@ static void curl_dump_info(char *data, size_t size)
822
strbuf_release(&buf);
823
}
824
824
-static int curl_trace(CURL *handle, curl_infotype type, char *data, size_t size, void *userp)
825
+static int curl_trace(CURL *handle UNUSED, curl_infotype type,
826
+ char *data, size_t size,
827
+ void *userp UNUSED)
828
{
829
const char *text;
830
enum { NO_FILTER = 0, DO_FILTER = 1 };