t3404: todo list with commented-out commands only aborts

If the todo list generated by `--make-script` is empty, complete_action() writes a noop, but if it has only commented-out commands, it will abort with the message "Nothing to do", and does not launch the editor. This adds a new test to ensure that complete_action() behaves this way. Signed-off-by: Alban Gruin <alban.gruin@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Alban Gruin committed Aug 10, 2018 at 18:51 UTC d078c39106895b26512ca6b259d66fe64b274e1b
1 file changed +10
t/t3404-rebase-interactive.sh
+10
@@ -75,6 +75,16 @@ test_expect_success 'rebase --keep-empty' '
75 test_line_count = 6 actual
76 '
77
78 +cat > expect <<EOF
79 +Nothing to do
80 +EOF
81 +
82 +test_expect_success 'rebase -i with empty HEAD' '
83 + set_fake_editor &&
84 + test_must_fail env FAKE_LINES="1 exec_true" git rebase -i HEAD^ >actual 2>&1 &&
85 + test_i18ncmp expect actual
86 +'
87 +
88 test_expect_success 'rebase -i with the exec command' '
89 git checkout master &&
90 (